contrib/fasthttp
1
0
Fork 0
mirror of https://github.com/valyala/fasthttp.git synced 2026-06-13 15:46:49 +03:00
Code Issues Packages Projects Releases Wiki Activity

bug: file descriptor leak on z/OS s390x when FcntlInt fails (#2255) (#2285)

Browse Source
This commit is contained in:
Erik Dubbelboer
2026-06-06 17:30:35 +08:00
committed by GitHub
parent f3f769f74c
commit 44115f3838
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tcplisten/socket_zos_s390x.go
+13 -5
View File
@@ -10,10 +10,18 @@ import (
func newSocketCloexec(domain, typ, proto int) (int, error) { func newSocketCloexec(domain, typ, proto int) (int, error) {
fd, err := unix.Socket(domain, typ, proto) fd, err := unix.Socket(domain, typ, proto)
_, err = unix.FcntlInt(uintptr(fd), unix.F_SETFD, unix.FD_CLOEXEC) if err != nil {
_, err = unix.FcntlInt(uintptr(fd), unix.F_SETFL, unix.O_NONBLOCK) return -1, fmt.Errorf("cannot create listening socket: %w", err)
if err == nil {
return fd, nil
} }
return -1, fmt.Errorf("cannot create listening unblocked socket: %s", err) _, err = unix.FcntlInt(uintptr(fd), unix.F_SETFD, unix.FD_CLOEXEC)
if err != nil {
unix.Close(fd) //nolint:errcheck
return -1, fmt.Errorf("cannot mark listening socket close-on-exec: %w", err)
}
_, err = unix.FcntlInt(uintptr(fd), unix.F_SETFL, unix.O_NONBLOCK)
if err != nil {
unix.Close(fd) //nolint:errcheck
return -1, fmt.Errorf("cannot mark listening socket nonblocking: %w", err)
}
return fd, nil
} }