From dc9b54dbdf553b3f8d970b051f43641e14c64cb2 Mon Sep 17 00:00:00 2001 From: Oleg Kovalov Date: Wed, 25 Sep 2019 20:56:31 +0200 Subject: [PATCH] Precompute default regexp (#662) --- expvarhandler/expvar.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/expvarhandler/expvar.go b/expvarhandler/expvar.go index 0c76368..6254baa 100644 --- a/expvarhandler/expvar.go +++ b/expvarhandler/expvar.go @@ -13,6 +13,8 @@ import ( var ( expvarHandlerCalls = expvar.NewInt("expvarHandlerCalls") expvarRegexpErrors = expvar.NewInt("expvarRegexpErrors") + + defaultRE = regexp.MustCompile(".") ) // ExpvarHandler dumps json representation of expvars to http response. @@ -52,7 +54,7 @@ func ExpvarHandler(ctx *fasthttp.RequestCtx) { func getExpvarRegexp(ctx *fasthttp.RequestCtx) (*regexp.Regexp, error) { r := string(ctx.QueryArgs().Peek("r")) if len(r) == 0 { - r = "." + return defaultRE, nil } rr, err := regexp.Compile(r) if err != nil {