mirror of
https://github.com/valyala/fasthttp.git
synced 2026-06-14 15:56:44 +03:00
Erik Dubbelboer
39dd1045bb
This means we can't skip parsing headers for GET requests anymore. This can be seen as good as it also allows us to reject malformed GET requests, something we didn't do before this. Performance also isn't affect much: benchmark old ns/op new ns/op delta BenchmarkClientGetEndToEnd1Inmemory-16 640 641 +0.16% BenchmarkClientGetEndToEnd10Inmemory-16 713 710 -0.42% BenchmarkClientGetEndToEnd100Inmemory-16 732 749 +2.32% BenchmarkClientGetEndToEnd1000Inmemory-16 759 774 +1.98% BenchmarkClientGetEndToEnd10KInmemory-16 785 808 +2.93% BenchmarkNetHTTPClientGetEndToEnd1Inmemory-16 5045 4954 -1.80% BenchmarkNetHTTPClientGetEndToEnd10Inmemory-16 5806 6225 +7.22% BenchmarkNetHTTPClientGetEndToEnd100Inmemory-16 7877 7998 +1.54% BenchmarkNetHTTPClientGetEndToEnd1000Inmemory-16 16603 16559 -0.27%
88 lines
2.4 KiB
Go
88 lines
2.4 KiB
Go
package fasthttp
|
|
|
|
import (
|
|
"bufio"
|
|
"bytes"
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestIssue28ResponseWithoutBodyNoContentType(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
var r Response
|
|
|
|
// Empty response without content-type
|
|
s := r.String()
|
|
if strings.Contains(s, "Content-Type") {
|
|
t.Fatalf("unexpected Content-Type found in response header with empty body: %q", s)
|
|
}
|
|
|
|
// Explicitly set content-type
|
|
r.Header.SetContentType("foo/bar")
|
|
s = r.String()
|
|
if !strings.Contains(s, "Content-Type: foo/bar\r\n") {
|
|
t.Fatalf("missing explicitly set content-type for empty response: %q", s)
|
|
}
|
|
|
|
// Non-empty response.
|
|
r.Reset()
|
|
r.SetBodyString("foobar")
|
|
s = r.String()
|
|
if !strings.Contains(s, fmt.Sprintf("Content-Type: %s\r\n", defaultContentType)) {
|
|
t.Fatalf("missing default content-type for non-empty response: %q", s)
|
|
}
|
|
|
|
// Non-empty response with custom content-type.
|
|
r.Header.SetContentType("aaa/bbb")
|
|
s = r.String()
|
|
if !strings.Contains(s, "Content-Type: aaa/bbb\r\n") {
|
|
t.Fatalf("missing custom content-type: %q", s)
|
|
}
|
|
}
|
|
|
|
func TestIssue6RequestHeaderSetContentType(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
testIssue6RequestHeaderSetContentType(t, MethodGet)
|
|
testIssue6RequestHeaderSetContentType(t, MethodPost)
|
|
testIssue6RequestHeaderSetContentType(t, MethodPut)
|
|
testIssue6RequestHeaderSetContentType(t, MethodPatch)
|
|
}
|
|
|
|
func testIssue6RequestHeaderSetContentType(t *testing.T, method string) {
|
|
contentType := "application/json"
|
|
contentLength := 123
|
|
|
|
var h RequestHeader
|
|
h.SetMethod(method)
|
|
h.SetRequestURI("http://localhost/test")
|
|
h.SetContentType(contentType)
|
|
h.SetContentLength(contentLength)
|
|
|
|
issue6VerifyRequestHeader(t, &h, contentType, contentLength, method)
|
|
|
|
s := h.String()
|
|
|
|
var h1 RequestHeader
|
|
|
|
br := bufio.NewReader(bytes.NewBufferString(s))
|
|
if err := h1.Read(br); err != nil {
|
|
t.Fatalf("unexpected error: %s", err)
|
|
}
|
|
issue6VerifyRequestHeader(t, &h1, contentType, contentLength, method)
|
|
}
|
|
|
|
func issue6VerifyRequestHeader(t *testing.T, h *RequestHeader, contentType string, contentLength int, method string) {
|
|
if string(h.ContentType()) != contentType {
|
|
t.Fatalf("unexpected content-type: %q. Expecting %q. method=%q", h.ContentType(), contentType, method)
|
|
}
|
|
if string(h.Method()) != method {
|
|
t.Fatalf("unexpected method: %q. Expecting %q", h.Method(), method)
|
|
}
|
|
if h.ContentLength() != contentLength {
|
|
t.Fatalf("unexpected content-length: %d. Expecting %d. method=%q", h.ContentLength(), contentLength, method)
|
|
}
|
|
}
|