diff --git a/adcom1/asset.go b/adcom1/asset.go index 7d358c0..7f2892c 100644 --- a/adcom1/asset.go +++ b/adcom1/asset.go @@ -11,7 +11,7 @@ type Asset struct { // integer // Definition: // The value of AssetFormat.id if this ad references a specific native placement defined by a Placement object and its structure. - ID int `json:"id,omitempty"` // TODO: confirm type when get to AssetFormat + ID int `json:"id,omitempty"` // Attribute: // req diff --git a/adcom1/content.go b/adcom1/content.go index 2c2ab66..389d5e9 100644 --- a/adcom1/content.go +++ b/adcom1/content.go @@ -172,7 +172,7 @@ type Content struct { // integer // Definition: // Source relationship, where 0 = indirect, 1 = direct. - SrcRel int8 `json:"srcrel,omitempty"` // TODO: make enum?.. + SrcRel int8 `json:"srcrel,omitempty"` // Attribute: // len diff --git a/adcom1/event.go b/adcom1/event.go index ffc45f7..a2b3afd 100644 --- a/adcom1/event.go +++ b/adcom1/event.go @@ -47,7 +47,7 @@ type Event struct { // Definition: // An array of key-value pairs to support vendor-specific data required for custom tracking. // For example, the account number of a buyer with a tracking company might be represented as: {"acct": "123"}. - CData map[string]string `json:"cdata,omitempty"` // TODO: confirm type - probably, need map[string]json.RawMessage? + CData map[string]string `json:"cdata,omitempty"` // Attribute: // ext diff --git a/adcom1/placement.go b/adcom1/placement.go index 63b05ca..7ca26ec 100644 --- a/adcom1/placement.go +++ b/adcom1/placement.go @@ -22,7 +22,7 @@ type Placement struct { // Integer; default 0 // Definition: // Indicates if server-side ad insertion (e.g., stitching an ad into an audio or video stream) is in use and the impact of this on asset and tracker retrieval, where 0 = status unknown, 1 = all client-side (i.e., not server-side), 2 = assets stitched server-side but tracking pixels fired client-side, 3 = all server-side. - SSAI int8 `json:"ssai,omitempty"` // TODO: make an enum? + SSAI int8 `json:"ssai,omitempty"` // Attribute: // sdk diff --git a/adcom1/user.go b/adcom1/user.go index 70b49f1..c4e579e 100644 --- a/adcom1/user.go +++ b/adcom1/user.go @@ -30,7 +30,7 @@ type User struct { // integer // Definition: // Year of birth as a 4-digit integer. - YOB int `json:"yob,omitempty"` // TODO: make smaller int? int16 should cover it. + YOB uint16 `json:"yob,omitempty"` // Attribute: // gender diff --git a/adcom1/video_placement_subtype.go b/adcom1/video_placement_subtype.go index f1b44c2..4c186b8 100644 --- a/adcom1/video_placement_subtype.go +++ b/adcom1/video_placement_subtype.go @@ -1,7 +1,7 @@ package adcom // VideoPlacementSubtype represents types of video placements derived largely from the IAB Digital Video Guidelines. -type VideoPlacementSubtype int // TODO: rename?.. It's "List: Placement Subtypes - Video" in spec. +type VideoPlacementSubtype int // Types of video placements derived largely from the IAB Digital Video Guidelines. const (