From 9238934b5fc6ddfaadfcf7a1b88d71afda5c91d4 Mon Sep 17 00:00:00 2001 From: Max Cherry Date: Sat, 30 May 2015 12:35:49 +0300 Subject: [PATCH] reviewed struct key types --- 2.3/rtb/deal.go | 2 +- README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/2.3/rtb/deal.go b/2.3/rtb/deal.go index ea15d0d..b0bcf1c 100644 --- a/2.3/rtb/deal.go +++ b/2.3/rtb/deal.go @@ -28,7 +28,7 @@ type Deal struct { // Type: // string // Description: - // Currency specified using ISO-4217 alpha codes. This may be different from bid currency returned + // Currency specified using ISO-4217 alpha codes. This may be different from bid currency returned // by bidder if this is allowed by the exchange. BidFloorCur string `json:"bidfloorcur"` diff --git a/README.md b/README.md index 6edb3d7..2c82ba9 100644 --- a/README.md +++ b/README.md @@ -33,7 +33,7 @@ Common [OpenRTB](//github.com/openrtb/OpenRTB) [v2.3](//github.com/openrtb/OpenR - [x] 4.2.3 Object: Bid - [ ] Code quality/review - [x] Review struct key types, which refer to section "5. Enumerated Lists Specification" - - [ ] Check types for struct keys (see Guidelines - Types) + - [x] Check types for struct keys (see Guidelines - Types) - [x] Use struct pointers for optional keys (e.g., App.Content) - [ ] Add json directive "omitempty" for optional keys