From ec6a1015f2d2d84e4670235f6cdf9c56d2e1e7ae Mon Sep 17 00:00:00 2001 From: Max Cherry Date: Sat, 3 Mar 2018 09:59:20 +0200 Subject: [PATCH] Removed TODO - not really needed Integral types are fine to remain int8/int64/uint64 RawJSON -> json.RawMessage switch is done Open enums - optional, can be done later if bored --- README.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/README.md b/README.md index 3643f00..b6ba5d5 100644 --- a/README.md +++ b/README.md @@ -49,8 +49,3 @@ Master always contains latest code, so better use some package manager to vendor - Each RTB type should be kept in its own file, named after type - File names are in underscore_case, e.g., `type BidRequest` should be declared in `bid_request.go` - [go fmt your code](https://blog.golang.org/go-fmt-your-code) - -# TODO -- [ ] Review all integral types, probably, switch everything to signed ones or just to `int`? -- [ ] Consider switching back to `encoding/json.RawMessage`, as Go 1.8 fixed serialisation for non-ptr (probably, when Go 1.9 or even 1.10 is out) -- [ ] Review types, that are enums (or "open enums" like `BidRequest.at`) themselves, but not described in section 5 - make them typed