From 1fffdc32f10f5b7af9bc848768011ca8ed6bd09d Mon Sep 17 00:00:00 2001 From: Ben Ramsey Date: Wed, 25 Jun 2025 08:18:24 -0500 Subject: [PATCH] Call getFields() only once --- src/Codec/OrderedTimeCodec.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/Codec/OrderedTimeCodec.php b/src/Codec/OrderedTimeCodec.php index f24f71b..ea533d9 100644 --- a/src/Codec/OrderedTimeCodec.php +++ b/src/Codec/OrderedTimeCodec.php @@ -87,12 +87,10 @@ class OrderedTimeCodec extends StringCodec $uuid = parent::decodeBytes($rearrangedBytes); - if ( - /** @phpstan-ignore possiblyImpure.methodCall */ - !($uuid->getFields() instanceof Rfc4122FieldsInterface) - /** @phpstan-ignore possiblyImpure.methodCall */ - || $uuid->getFields()->getVersion() !== Uuid::UUID_TYPE_TIME - ) { + /** @phpstan-ignore possiblyImpure.methodCall */ + $fields = $uuid->getFields(); + + if (!$fields instanceof Rfc4122FieldsInterface || $fields->getVersion() !== Uuid::UUID_TYPE_TIME) { throw new UnsupportedOperationException( 'Attempting to decode a non-time-based UUID using OrderedTimeCodec', );