From 89d91a97eb8b83c64706fbd5935c4350a498ebc0 Mon Sep 17 00:00:00 2001 From: Thibaud Fabre Date: Thu, 13 Aug 2015 17:44:02 +0200 Subject: [PATCH] Remove unnecessary conversions in BigNumberConverter Using the baseConvert method from BigNumber uses two consecutive convert operations: - convertToBase10 - convertFromBase10 In BigNumberConverters context, we can directly call each specific method to avoid the conversion overhead. --- src/Converter/Number/BigNumberConverter.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Converter/Number/BigNumberConverter.php b/src/Converter/Number/BigNumberConverter.php index f84b645..7ab5c49 100644 --- a/src/Converter/Number/BigNumberConverter.php +++ b/src/Converter/Number/BigNumberConverter.php @@ -23,7 +23,7 @@ class BigNumberConverter implements NumberConverterInterface */ public function fromHex($hex) { - $number = \Moontoast\Math\BigNumber::baseConvert($hex, 16, 10); + $number = \Moontoast\Math\BigNumber::convertToBase10($hex, 16); return new \Moontoast\Math\BigNumber($number); } @@ -34,6 +34,6 @@ class BigNumberConverter implements NumberConverterInterface $integer = new \Moontoast\Math\BigNumber($integer); } - return \Moontoast\Math\BigNumber::baseConvert($integer, 10, 16); + return \Moontoast\Math\BigNumber::convertFromBase10($integer, 16); } }