mirror of
https://github.com/ramsey/uuid.git
synced 2026-06-14 15:56:48 +03:00
Fix pure annotations (#605)
Coming from https://github.com/ramsey/uuid/pull/603, this is an attempt to fix the errors raised by the current phpstan settings. I went through each of the errors raised by phpstan with the following approach. - If a method is part of an `@immutable` class, we can consider it pure, assuming it only affects internal variables. - If a potentially pure method is calling a class's method that is only swapped during testing (and not during normal usage), then we can consider the calling method pure. - If a class is marked deprecated, don't bother with attempting to mark it pure or immutable.
This commit is contained in:
committed by
Ben Ramsey
parent
df575bdb79
commit
aa18ce15d5
@@ -77,6 +77,7 @@ class OrderedTimeCodecTest extends TestCase
|
||||
->method('getFields')
|
||||
->willReturn($this->fields);
|
||||
$codec = new OrderedTimeCodec($this->builder);
|
||||
/** @phpstan-ignore method.resultUnused */
|
||||
$codec->encode($this->uuid);
|
||||
}
|
||||
|
||||
@@ -165,6 +166,7 @@ class OrderedTimeCodecTest extends TestCase
|
||||
$this->expectException(InvalidArgumentException::class);
|
||||
$this->expectExceptionMessage('Expected version 1 (time-based) UUID');
|
||||
|
||||
/** @phpstan-ignore method.resultUnused */
|
||||
$codec->encodeBinary($uuid);
|
||||
}
|
||||
|
||||
@@ -185,6 +187,7 @@ class OrderedTimeCodecTest extends TestCase
|
||||
$this->expectException(InvalidArgumentException::class);
|
||||
$this->expectExceptionMessage('Expected version 1 (time-based) UUID');
|
||||
|
||||
/** @phpstan-ignore method.resultUnused */
|
||||
$codec->encodeBinary($uuid);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user