Fix pure annotations (#605)

Coming from https://github.com/ramsey/uuid/pull/603, this is an attempt
to fix the errors raised by the current phpstan settings.

I went through each of the errors raised by phpstan with the following
approach.

- If a method is part of an `@immutable` class, we can consider it pure,
  assuming it only affects internal variables.
- If a potentially pure method is calling a class's method that is only
  swapped during testing (and not during normal usage), then we can
  consider the calling method pure.
- If a class is marked deprecated, don't bother with attempting to mark
  it pure or immutable.
This commit is contained in:
Brandon Morrison
2025-06-24 20:28:52 -05:00
committed by Ben Ramsey
parent df575bdb79
commit aa18ce15d5
54 changed files with 217 additions and 21 deletions
+2
View File
@@ -60,6 +60,7 @@ class StringCodecTest extends TestCase
->method('getFields')
->willReturn($this->fields);
$codec = new StringCodec($this->builder);
/** @phpstan-ignore method.resultUnused */
$codec->encode($this->uuid);
}
@@ -135,6 +136,7 @@ class StringCodecTest extends TestCase
$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('$bytes string should contain 16 characters.');
/** @phpstan-ignore method.resultUnused */
$codec->decodeBytes($bytes);
}