mirror of
https://github.com/ramsey/uuid.git
synced 2026-06-17 16:26:51 +03:00
Fix pure annotations (#605)
Coming from https://github.com/ramsey/uuid/pull/603, this is an attempt to fix the errors raised by the current phpstan settings. I went through each of the errors raised by phpstan with the following approach. - If a method is part of an `@immutable` class, we can consider it pure, assuming it only affects internal variables. - If a potentially pure method is calling a class's method that is only swapped during testing (and not during normal usage), then we can consider the calling method pure. - If a class is marked deprecated, don't bother with attempting to mark it pure or immutable.
This commit is contained in:
committed by
Ben Ramsey
parent
df575bdb79
commit
aa18ce15d5
@@ -73,6 +73,7 @@ final class UuidGenerationBench
|
||||
|
||||
public function benchUuid3Generation(): void
|
||||
{
|
||||
/** @phpstan-ignore staticMethod.resultUnused */
|
||||
Uuid::uuid3($this->namespace, 'name');
|
||||
}
|
||||
|
||||
@@ -83,6 +84,7 @@ final class UuidGenerationBench
|
||||
|
||||
public function benchUuid5Generation(): void
|
||||
{
|
||||
/** @phpstan-ignore staticMethod.resultUnused */
|
||||
Uuid::uuid5($this->namespace, 'name');
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user