From dee551deb1fc798bca2bfeab7bbd7ae24a6bd218 Mon Sep 17 00:00:00 2001
From: Marco Pivetta <ocramius@gmail.com>
Date: Mon, 3 Feb 2020 18:18:43 +0100
Subject: [PATCH] Removed `use function` imports for mocked/stubbed functions,
 disabling phpcs import rule

While the rule is now disabled, it still is very much valuable to import most pure functions from the core
PHP scope, allowing us some marginal gains on anything that can be inlined by the engine (now or in future).

The rule does not allow selective exclusions, so we will need to keep it off for now.
---
 phpcs.xml.dist                                 | 1 -
 src/Converter/Time/PhpTimeConverter.php        | 1 -
 src/Generator/DefaultTimeGenerator.php         | 2 +-
 src/Generator/RandomBytesGenerator.php         | 2 --
 src/Provider/Dce/SystemDceSecurityProvider.php | 3 ---
 src/Provider/Node/RandomNodeProvider.php       | 1 -
 src/Provider/Node/SystemNodeProvider.php       | 6 ------
 src/Provider/Time/SystemTimeProvider.php       | 2 --
 8 files changed, 1 insertion(+), 17 deletions(-)

diff --git a/phpcs.xml.dist b/phpcs.xml.dist
index e972afa..abf6f4b 100644
--- a/phpcs.xml.dist
+++ b/phpcs.xml.dist
@@ -241,7 +241,6 @@
     <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly">
         <properties>
             <property name="allowFallbackGlobalConstants" value="false"/>
-            <property name="allowFallbackGlobalFunctions" value="false"/>
             <property name="allowFullyQualifiedGlobalConstants" value="false"/>
             <property name="allowFullyQualifiedGlobalFunctions" value="false"/>
             <property name="allowFullyQualifiedExceptions" value="true"/>
diff --git a/src/Converter/Time/PhpTimeConverter.php b/src/Converter/Time/PhpTimeConverter.php
index 1b1e198..eabae74 100644
--- a/src/Converter/Time/PhpTimeConverter.php
+++ b/src/Converter/Time/PhpTimeConverter.php
@@ -24,7 +24,6 @@ use Ramsey\Uuid\Type\Time;
 use function count;
 use function dechex;
 use function explode;
-use function ini_get;
 use function is_float;
 use function is_int;
 use function str_pad;
diff --git a/src/Generator/DefaultTimeGenerator.php b/src/Generator/DefaultTimeGenerator.php
index f82d663..3feea5c 100644
--- a/src/Generator/DefaultTimeGenerator.php
+++ b/src/Generator/DefaultTimeGenerator.php
@@ -27,7 +27,7 @@ use function dechex;
 use function hex2bin;
 use function is_int;
 use function pack;
-use function random_int;
+use function sprintf;
 use function str_pad;
 use function strlen;
 
diff --git a/src/Generator/RandomBytesGenerator.php b/src/Generator/RandomBytesGenerator.php
index dcf6ad8..e6e9a19 100644
--- a/src/Generator/RandomBytesGenerator.php
+++ b/src/Generator/RandomBytesGenerator.php
@@ -16,8 +16,6 @@ namespace Ramsey\Uuid\Generator;
 
 use Ramsey\Uuid\Exception\RandomSourceException;
 
-use function random_bytes;
-
 /**
  * RandomBytesGenerator generates strings of random binary data using the
  * built-in `random_bytes()` PHP function
diff --git a/src/Provider/Dce/SystemDceSecurityProvider.php b/src/Provider/Dce/SystemDceSecurityProvider.php
index 18f0d5e..1ee12bd 100644
--- a/src/Provider/Dce/SystemDceSecurityProvider.php
+++ b/src/Provider/Dce/SystemDceSecurityProvider.php
@@ -18,11 +18,8 @@ use Ramsey\Uuid\Exception\DceSecurityException;
 use Ramsey\Uuid\Provider\DceSecurityProviderInterface;
 use Ramsey\Uuid\Type\IntegerValue;
 
-use function constant;
 use function escapeshellarg;
-use function ini_get;
 use function preg_split;
-use function shell_exec;
 use function str_getcsv;
 use function strpos;
 use function strrpos;
diff --git a/src/Provider/Node/RandomNodeProvider.php b/src/Provider/Node/RandomNodeProvider.php
index e4c10e7..aa3a3d1 100644
--- a/src/Provider/Node/RandomNodeProvider.php
+++ b/src/Provider/Node/RandomNodeProvider.php
@@ -21,7 +21,6 @@ use function bin2hex;
 use function dechex;
 use function hex2bin;
 use function hexdec;
-use function random_bytes;
 use function str_pad;
 use function substr;
 
diff --git a/src/Provider/Node/SystemNodeProvider.php b/src/Provider/Node/SystemNodeProvider.php
index 9c19c45..486f194 100644
--- a/src/Provider/Node/SystemNodeProvider.php
+++ b/src/Provider/Node/SystemNodeProvider.php
@@ -19,16 +19,10 @@ use Ramsey\Uuid\Provider\NodeProviderInterface;
 use function array_filter;
 use function array_map;
 use function array_walk;
-use function constant;
 use function count;
-use function file_get_contents;
-use function glob;
-use function ini_get;
 use function is_array;
-use function is_readable;
 use function ob_get_clean;
 use function ob_start;
-use function passthru;
 use function preg_match;
 use function preg_match_all;
 use function reset;
diff --git a/src/Provider/Time/SystemTimeProvider.php b/src/Provider/Time/SystemTimeProvider.php
index 8958c48..93ff01f 100644
--- a/src/Provider/Time/SystemTimeProvider.php
+++ b/src/Provider/Time/SystemTimeProvider.php
@@ -17,8 +17,6 @@ namespace Ramsey\Uuid\Provider\Time;
 use Ramsey\Uuid\Provider\TimeProviderInterface;
 use Ramsey\Uuid\Type\Time;
 
-use function gettimeofday;
-
 /**
  * SystemTimeProvider retrieves the current time using built-in PHP functions
  */