From 795349d796cabcc83e75b69a6178ac4c3e9367e4 Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Sat, 6 Jun 2026 18:02:36 -0700 Subject: [PATCH] test(s3): deref Object.Size in versioned list assertion (#9843) TestVersionedObjectListBehavior compared int64 against listedObject.Size, which is *int64, so the assertion always failed on a type mismatch once reached. Dereference it (and in the log line). --- test/s3/versioning/s3_directory_versioning_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/s3/versioning/s3_directory_versioning_test.go b/test/s3/versioning/s3_directory_versioning_test.go index 9138eac7e..eae7b8e9b 100644 --- a/test/s3/versioning/s3_directory_versioning_test.go +++ b/test/s3/versioning/s3_directory_versioning_test.go @@ -664,7 +664,7 @@ func TestVersionedObjectListBehavior(t *testing.T) { assert.NotContains(t, *listedObject.Key, versionId, "Object key should not contain version ID") // Verify object properties - assert.Equal(t, int64(len(content)), listedObject.Size, "Object size should match") + assert.Equal(t, int64(len(content)), *listedObject.Size, "Object size should match") assert.NotNil(t, listedObject.ETag, "Object should have ETag") assert.NotNil(t, listedObject.LastModified, "Object should have LastModified") @@ -674,7 +674,7 @@ func TestVersionedObjectListBehavior(t *testing.T) { assert.NotEmpty(t, listedObject.Owner.DisplayName, "Owner DisplayName should not be empty") t.Logf("Listed object: Key=%s, Size=%d, Owner.ID=%s, Owner.DisplayName=%s", - *listedObject.Key, listedObject.Size, *listedObject.Owner.ID, *listedObject.Owner.DisplayName) + *listedObject.Key, *listedObject.Size, *listedObject.Owner.ID, *listedObject.Owner.DisplayName) // Test list-objects-v2 operation as well listV2Resp, err := client.ListObjectsV2(context.TODO(), &s3.ListObjectsV2Input{