mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-06-13 23:36:45 +03:00
Chris Lu
4f17c6661a
Random allocation could pick 33646 = admin.port (23646) + GrpcPortOffset. weed mini reserves that as Admin's gRPC port even when the test only overrides Master/Filer/S3/Iceberg, so the explicit Filer flag failed with "reserved for gRPC calculation" and TestRisingWaveIcebergCatalog flaked. Pre-seed the reserved set with every mini default HTTP port plus its +10000 offset so a random pick (or its own gRPC offset) cannot land on a service the caller left at its default.
53 lines
1.7 KiB
Go
53 lines
1.7 KiB
Go
package testutil
|
|
|
|
import "testing"
|
|
|
|
// AllocateMiniPorts must never hand out a port that weed mini will reserve
|
|
// for one of its default services (or that default's gRPC offset). A real
|
|
// failure: Filer was given 33646 (Admin default 23646 + GrpcPortOffset),
|
|
// which mini then refused as "reserved for gRPC calculation".
|
|
func TestAllocateMiniPortsAvoidsMiniDefaults(t *testing.T) {
|
|
reserved := reservedMiniPorts()
|
|
for iter := 0; iter < 200; iter++ {
|
|
ports, err := AllocateMiniPorts(4)
|
|
if err != nil {
|
|
t.Fatalf("iter %d: AllocateMiniPorts: %v", iter, err)
|
|
}
|
|
for _, p := range ports {
|
|
if reserved[p] {
|
|
t.Fatalf("iter %d: allocated port %d is a mini default (or gRPC offset)", iter, p)
|
|
}
|
|
if reserved[p+GrpcPortOffset] {
|
|
t.Fatalf("iter %d: allocated port %d has gRPC offset %d colliding with a mini default",
|
|
iter, p, p+GrpcPortOffset)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestAllocatePortSetNoGrpcCollision(t *testing.T) {
|
|
// Run a few iterations to catch the OS-recycles-just-closed-port race
|
|
// that previously hit regular ports when the mini gRPC offset was freed
|
|
// between AllocateMiniPorts and AllocatePorts calls.
|
|
for iter := 0; iter < 20; iter++ {
|
|
mini, regular, err := AllocatePortSet(1, 3)
|
|
if err != nil {
|
|
t.Fatalf("iter %d: AllocatePortSet: %v", iter, err)
|
|
}
|
|
if len(mini) != 1 || len(regular) != 3 {
|
|
t.Fatalf("iter %d: unexpected counts mini=%d regular=%d", iter, len(mini), len(regular))
|
|
}
|
|
reserved := map[int]bool{
|
|
mini[0]: true,
|
|
mini[0] + GrpcPortOffset: true,
|
|
}
|
|
for _, p := range regular {
|
|
if reserved[p] {
|
|
t.Fatalf("iter %d: regular port %d collides with mini pair %d/%d",
|
|
iter, p, mini[0], mini[0]+GrpcPortOffset)
|
|
}
|
|
reserved[p] = true
|
|
}
|
|
}
|
|
}
|