mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-06-13 23:36:45 +03:00
Chris Lu
a24f4844d3
* mysql: keep S3 list order byte-lexicographic regardless of name column collation ORDER BY name and the name > ? pagination predicate follow the column collation, so a case-insensitive filemeta.name (e.g. utf8mb3_general_ci) returns S3 keys out of byte order and breaks clients that merge two sorted listings. Detect the live name collation at startup; only when it isn't binary, wrap the list comparison, prefix, and ORDER BY in BINARY name so order and pagination stay consistent. Correctly configured utf8mb4_bin tables keep their indexed range scan unchanged, and the operator gets a warning to convert the column. * postgres: keep S3 list order byte-lexicographic regardless of name column collation ORDER BY name and the name > $n pagination predicate follow the column or database collation, so a locale-aware filemeta.name (e.g. the en_US.UTF-8 database default) returns S3 keys out of byte order and breaks clients that merge two sorted listings. Detect the live name collation at startup; only when it isn't byte-ordered, wrap the list comparison, prefix, and ORDER BY in COLLATE "C" so order and pagination stay consistent. A byte-ordered (C/POSIX/C.UTF-8) column keeps its indexed range scan unchanged, and the operator gets a warning to declare the column COLLATE "C".
76 lines
2.7 KiB
Go
76 lines
2.7 KiB
Go
package postgres
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
_ "github.com/jackc/pgx/v5/stdlib"
|
|
"github.com/seaweedfs/seaweedfs/weed/filer/abstract_sql"
|
|
)
|
|
|
|
type SqlGenPostgres struct {
|
|
CreateTableSqlTemplate string
|
|
DropTableSqlTemplate string
|
|
UpsertQueryTemplate string
|
|
// Force byte ordering on a locale-aware name column; see ConfigureListOrdering.
|
|
ForceBinaryCollation bool
|
|
}
|
|
|
|
// DefaultUpsertQuery keeps INSERTs idempotent so a duplicate-key failure
|
|
// (23505) cannot poison the surrounding transaction (25P02). Used when the
|
|
// user enables upsert but does not provide their own template.
|
|
const DefaultUpsertQuery = `INSERT INTO "%s" (dirhash,name,directory,meta) VALUES($1,$2,$3,$4) ON CONFLICT (dirhash, name) DO UPDATE SET directory=EXCLUDED.directory, meta=EXCLUDED.meta`
|
|
|
|
var (
|
|
_ = abstract_sql.SqlGenerator(&SqlGenPostgres{})
|
|
)
|
|
|
|
func (gen *SqlGenPostgres) GetSqlInsert(tableName string) string {
|
|
if gen.UpsertQueryTemplate != "" {
|
|
return fmt.Sprintf(gen.UpsertQueryTemplate, tableName)
|
|
} else {
|
|
return fmt.Sprintf(`INSERT INTO "%s" (dirhash,name,directory,meta) VALUES($1,$2,$3,$4)`, tableName)
|
|
}
|
|
}
|
|
|
|
func (gen *SqlGenPostgres) GetSqlUpdate(tableName string) string {
|
|
return fmt.Sprintf(`UPDATE "%s" SET meta=$1 WHERE dirhash=$2 AND name=$3 AND directory=$4`, tableName)
|
|
}
|
|
|
|
func (gen *SqlGenPostgres) GetSqlFind(tableName string) string {
|
|
return fmt.Sprintf(`SELECT meta FROM "%s" WHERE dirhash=$1 AND name=$2 AND directory=$3`, tableName)
|
|
}
|
|
|
|
func (gen *SqlGenPostgres) GetSqlDelete(tableName string) string {
|
|
return fmt.Sprintf(`DELETE FROM "%s" WHERE dirhash=$1 AND name=$2 AND directory=$3`, tableName)
|
|
}
|
|
|
|
func (gen *SqlGenPostgres) GetSqlDeleteFolderChildren(tableName string) string {
|
|
return fmt.Sprintf(`DELETE FROM "%s" WHERE dirhash=$1 AND directory=$2`, tableName)
|
|
}
|
|
|
|
// nameExpr forces byte ordering on a locale-aware column via COLLATE "C".
|
|
func (gen *SqlGenPostgres) nameExpr() string {
|
|
if gen.ForceBinaryCollation {
|
|
return `name COLLATE "C"`
|
|
}
|
|
return "name"
|
|
}
|
|
|
|
func (gen *SqlGenPostgres) GetSqlListExclusive(tableName string) string {
|
|
name := gen.nameExpr()
|
|
return fmt.Sprintf(`SELECT NAME, meta FROM "%s" WHERE dirhash=$1 AND %s>$2 AND directory=$3 AND %s like $4 ORDER BY %s ASC LIMIT $5`, tableName, name, name, name)
|
|
}
|
|
|
|
func (gen *SqlGenPostgres) GetSqlListInclusive(tableName string) string {
|
|
name := gen.nameExpr()
|
|
return fmt.Sprintf(`SELECT NAME, meta FROM "%s" WHERE dirhash=$1 AND %s>=$2 AND directory=$3 AND %s like $4 ORDER BY %s ASC LIMIT $5`, tableName, name, name, name)
|
|
}
|
|
|
|
func (gen *SqlGenPostgres) GetSqlCreateTable(tableName string) string {
|
|
return fmt.Sprintf(gen.CreateTableSqlTemplate, tableName)
|
|
}
|
|
|
|
func (gen *SqlGenPostgres) GetSqlDropTable(tableName string) string {
|
|
return fmt.Sprintf(gen.DropTableSqlTemplate, tableName)
|
|
}
|