viaprog/shaka-player
1
0
Fork 0
mirror of https://github.com/shaka-project/shaka-player.git synced 2026-06-14 15:56:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix library load and polyfill for old browsers

Browse Source 
This will allow support-testing to work on older browsers so that
application developers can still load the library and query for
support to show an appropriate error message.

To accomplish this, we avoid load-time uses of Function.bind, avoid
certain polyfills if modern types are not available, and compile down
to ES3 to avoid errors caused by use of the reserved word "catch" on
Promises.

This has been tested back to IE6, Safari 5.1, iOS 6.0, Firefox 6,
Chrome 15, and Opera 16.

Change-Id: I9deed106a7736758e04452ef85bae40f37c6fe62
This commit is contained in:
Joey Parrish
2015-12-09 15:43:25 -08:00
parent 5616a47c72
commit 3e7014db2b
7 changed files with 59 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/debug/log.js
+38 -68
View File
@@ -69,75 +69,45 @@ shaka.log.v1 = function() {};
shaka.log.v2 = function() {};
/**
* @private
* @param {string} logName
*/
shaka.log.patchConsole_ = function(logName) {
var nop = function() {};
var logFunction = console[logName];
// IE8 has no console unless it is opened in advance.
// IE9 console methods are not Functions and have no bind.
if (window.console && window.console.log.bind) {
if (!COMPILED) {
/**
* Change the log level. Useful for debugging in uncompiled mode.
*
* @param {number} level
*/
shaka.log.setLevel = function(level) {
var nop = function() {};
var log = shaka.log;
var Level = shaka.log.Level;
if (!logFunction) {
console[logName] = nop;
} else if (!logFunction.bind) {
// IE 9 does not provide a .bind for the built-in logging functions.
console[logName] = function() {
logFunction.apply(console, arguments);
log.error = (level >= Level.ERROR) ? console.error.bind(console) : nop;
log.warning = (level >= Level.WARNING) ? console.warn.bind(console) : nop;
log.info = (level >= Level.INFO) ? console.info.bind(console) : nop;
log.debug = (level >= Level.DEBUG) ? console.log.bind(console) : nop;
log.v1 = (level >= Level.V1) ? console.debug.bind(console) : nop;
log.v2 = (level >= Level.V2) ? console.debug.bind(console) : nop;
};
} else {
if (shaka.log.MAX_LOG_LEVEL >= shaka.log.Level.ERROR) {
shaka.log.error = console.error.bind(console);
}
if (shaka.log.MAX_LOG_LEVEL >= shaka.log.Level.WARNING) {
shaka.log.warning = console.warn.bind(console);
}
if (shaka.log.MAX_LOG_LEVEL >= shaka.log.Level.INFO) {
shaka.log.info = console.info.bind(console);
}
if (shaka.log.MAX_LOG_LEVEL >= shaka.log.Level.DEBUG) {
shaka.log.debug = console.log.bind(console);
}
if (shaka.log.MAX_LOG_LEVEL >= shaka.log.Level.V1) {
shaka.log.v1 = console.debug.bind(console);
}
if (shaka.log.MAX_LOG_LEVEL >= shaka.log.Level.V2) {
shaka.log.v2 = console.debug.bind(console);
}
}
};
shaka.log.patchConsole_('error');
shaka.log.patchConsole_('warn');
shaka.log.patchConsole_('info');
shaka.log.patchConsole_('log');
shaka.log.patchConsole_('debug');
if (!COMPILED) {
/**
* Change the log level. Useful for debugging in uncompiled mode.
*
* @param {number} level
*/
shaka.log.setLevel = function(level) {
var nop = function() {};
var log = shaka.log;
var Level = shaka.log.Level;
log.error = (level >= Level.ERROR) ? console.error.bind(console) : nop;
log.warning = (level >= Level.WARNING) ? console.warn.bind(console) : nop;
log.info = (level >= Level.INFO) ? console.info.bind(console) : nop;
log.debug = (level >= Level.DEBUG) ? console.log.bind(console) : nop;
log.v1 = (level >= Level.V1) ? console.debug.bind(console) : nop;
log.v2 = (level >= Level.V2) ? console.debug.bind(console) : nop;
};
}
// Although these bindings are redundant with setLevel() above, refactoring to
// call a method here makes it so that the log messages themselves cannot be
// compiled out.
if (shaka.log.MAX_LOG_LEVEL >= shaka.log.Level.ERROR) {
shaka.log.error = console.error.bind(console);
}
if (shaka.log.MAX_LOG_LEVEL >= shaka.log.Level.WARNING) {
shaka.log.warning = console.warn.bind(console);
}
if (shaka.log.MAX_LOG_LEVEL >= shaka.log.Level.INFO) {
shaka.log.info = console.info.bind(console);
}
if (shaka.log.MAX_LOG_LEVEL >= shaka.log.Level.DEBUG) {
shaka.log.debug = console.log.bind(console);
}
if (shaka.log.MAX_LOG_LEVEL >= shaka.log.Level.V1) {
shaka.log.v1 = console.debug.bind(console);
}
if (shaka.log.MAX_LOG_LEVEL >= shaka.log.Level.V2) {
shaka.log.v2 = console.debug.bind(console);
}