From 89059f81e5c19d9fca9c6d7fccae53b6faf8f790 Mon Sep 17 00:00:00 2001 From: Joey Parrish Date: Fri, 1 May 2020 17:38:56 -0700 Subject: [PATCH] Remove bogus parts of IUIElement interface As an external, abstract interface, the constructor doesn't do anything. The members in it were parts of the base class shaka.ui.Element, which implementations of IUIElement can still inherit from. In fact, there is not much reason to have this empty IUIElement interface now, but we'll keep it for now to avoid breaking compiled applications. Change-Id: I5687b281be523c29656b5c51e63628ba164cf1b3 --- ui/externs/ui.js | 46 +--------------------------------------------- 1 file changed, 1 insertion(+), 45 deletions(-) diff --git a/ui/externs/ui.js b/ui/externs/ui.js index 29afa207c..e2807cd4b 100644 --- a/ui/externs/ui.js +++ b/ui/externs/ui.js @@ -145,51 +145,7 @@ shaka.extern.UIConfiguration; * @exportDoc */ shaka.extern.IUIElement = class { - /** - * @param {!HTMLElement} parent - * @param {!shaka.ui.Controls} controls - */ - constructor(parent, controls) { - /** - * @protected {HTMLElement} - * @exportDoc - */ - this.parent; - - /** - * @protected {shaka.ui.Controls} - * @exportDoc - */ - this.controls; - - /** - * @protected {shaka.util.EventManager} - * @exportDoc - */ - this.eventManager; - - /** - * @protected {shaka.ui.Localization} - * @exportDoc - */ - this.localization; - - /** - * @protected {shaka.Player} - * @exportDoc - */ - this.player; - - /** - * @protected {HTMLMediaElement} - * @exportDoc - */ - this.video; - } - - /** - * @override - */ + /** @override */ release() {} };