From b752f779cfde99bb6bfa4f7f7dec31bb4f64209e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wojciech=20Tyczy=C5=84ski?= Date: Fri, 6 Jun 2025 16:20:03 +0200 Subject: [PATCH] chore: Reduce same conditions in StreamingEngine (#8709) --- lib/media/streaming_engine.js | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/lib/media/streaming_engine.js b/lib/media/streaming_engine.js index e0b9f0ef7..3140317ec 100644 --- a/lib/media/streaming_engine.js +++ b/lib/media/streaming_engine.js @@ -2468,8 +2468,6 @@ shaka.media.StreamingEngine = class { stream.closedCaptions.size > 0; if (this.config_.shouldFixTimestampOffset) { - let parser; - const isMP4 = stream.mimeType == 'video/mp4' || stream.mimeType == 'audio/mp4'; let timescale = null; @@ -2481,11 +2479,7 @@ shaka.media.StreamingEngine = class { this.manifest_.type == shaka.media.ManifestParser.DASH; if (shouldFixTimestampOffset) { - parser = new shaka.util.Mp4Parser(); - } - - if (shouldFixTimestampOffset) { - parser + new shaka.util.Mp4Parser() .box('moof', shaka.util.Mp4Parser.children) .box('traf', shaka.util.Mp4Parser.children) .fullBox('tfdt', async (box) => { @@ -2519,11 +2513,8 @@ shaka.media.StreamingEngine = class { await this.setProperties_(mediaState, scaledMediaDecodeTime, lastAppendWindowStart, lastAppendWindowEnd, reference); } - }); - } - - if (shouldFixTimestampOffset) { - parser.parse(segment, /* partialOkay= */ false, isChunkedData); + }) + .parse(segment, /* partialOkay= */ false, isChunkedData); } }