viaprog/shaka-player
1
0
Fork 0
mirror of https://github.com/shaka-project/shaka-player.git synced 2026-06-16 16:16:40 +03:00
Code Issues Packages Projects Releases Wiki Activity

docs: Update PR template.

Browse Source 
- Puts the description info in a comment.
- Adds comments to screenshots section.
- Removes the comments telling people to remove checkbox lines.
- Adds new checklist items for CLA/build/test.

Change-Id: I2d3b66c9b1a16eb489f8d65526a17c4ad4e4fae9
This commit is contained in:
Jacob Trimble
2021-03-22 11:56:57 -07:00
parent 9fb637d82f
commit ea20df0fd8
1 changed files with 21 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/pull_request_template.md
+21 -11
View File
@@ -1,28 +1,38 @@
## Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
<!--
Give the PR a helpful title that summaries what this PR changes. Here, include
a summary of the change and which issue is fixed. Also include relevant
motivation and context. List any dependencies that are required for this
change.
If this fixes any issues, include lines like this:
Fixes #123
-->
Fixes # (issue)
## Screenshots (optional)
## Type of change
<!--
If you change the UI, add before and after screenshots demonstrating your
changes.
-->
<!--Please delete options that are not relevant.-->
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Breaking change (fix or feature that would cause existing functionality to
not work as expected)
- [ ] This change requires a documentation update
## Checklist:
<!--Please delete options that are not relevant.-->
- [ ] I have signed the Google CLA <https://cla.developers.google.com>
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] I have verified my change on multiple browsers on different platforms
- [ ] I have run `./build/all.py` and the build passes
- [ ] I have run `./build/test.py` and all tests pass