From 060ca73ae379beeffcbd657e145a249a79903468 Mon Sep 17 00:00:00 2001 From: Andy Hochhaus Date: Sat, 23 Jul 2016 14:16:19 -0700 Subject: [PATCH] Quote properties on window in tests --- test/cast/cast_receiver_unit.js | 6 +++--- test/cast/cast_sender_unit.js | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test/cast/cast_receiver_unit.js b/test/cast/cast_receiver_unit.js index 3fee4a6f5..efcbcacd3 100644 --- a/test/cast/cast_receiver_unit.js +++ b/test/cast/cast_receiver_unit.js @@ -58,7 +58,7 @@ describe('CastReceiver', function() { // Don't do any more work here if the tests will not end up running. if (!isChromecast && !isChrome) return; - originalCast = window.cast; + originalCast = window['cast']; originalUserAgent = navigator.userAgent; // In uncompiled mode, there is a UA check for Chromecast in order to make @@ -72,7 +72,7 @@ describe('CastReceiver', function() { afterAll(function() { if (originalUserAgent) { - window.cast = originalCast; + window['cast'] = originalCast; Object.defineProperty(window['navigator'], 'userAgent', {value: originalUserAgent}); } @@ -80,7 +80,7 @@ describe('CastReceiver', function() { beforeEach(function() { mockReceiverApi = createMockReceiverApi(); - window.cast = { receiver: mockReceiverApi }; + window['cast'] = { receiver: mockReceiverApi }; mockReceiverManager = createMockReceiverManager(); mockMessageBus = createMockMessageBus(); diff --git a/test/cast/cast_sender_unit.js b/test/cast/cast_sender_unit.js index acf0b0299..8d0f86efa 100644 --- a/test/cast/cast_sender_unit.js +++ b/test/cast/cast_sender_unit.js @@ -43,11 +43,11 @@ describe('CastSender', function() { CastSender = shaka.cast.CastSender; CastUtils = shaka.cast.CastUtils; - originalChrome = window.chrome; + originalChrome = window['chrome']; }); afterAll(function() { - window.chrome = originalChrome; + window['chrome'] = originalChrome; }); beforeEach(function() { @@ -56,7 +56,7 @@ describe('CastSender', function() { onResumeLocal = jasmine.createSpy('onResumeLocal'); mockCastApi = createMockCastApi(); - window.chrome = { cast: mockCastApi }; + window['chrome'] = { cast: mockCastApi }; mockSession = null; sender = new CastSender(fakeAppId, onStatusChanged, onRemoteEvent, @@ -71,7 +71,7 @@ describe('CastSender', function() { describe('init', function() { it('installs a callback if the cast API is not available', function() { // Remove the mock cast API. - delete window.chrome.cast; + delete window['chrome'].cast; // This shouldn't exist yet. expect(window.__onGCastApiAvailable).toBe(undefined); @@ -82,7 +82,7 @@ describe('CastSender', function() { expect(onStatusChanged).not.toHaveBeenCalled(); // Restore the mock cast API. - window.chrome.cast = mockCastApi; + window['chrome'].cast = mockCastApi; window.__onGCastApiAvailable(true); // Expect the API to be ready and initialized. expect(sender.apiReady()).toBe(true);