Commit Graph

3 Commits

Author SHA1 Message Date
Joey Parrish 65a2cfdda9 fix: Allow muxjs to be loaded after Shaka
In PR #2683, a dependency-injection system was added to Shaka Player.
However, it would capture default deps from a global scope at
load-time.  This introduced an accidental ordering requirement where
muxjs would have to be loaded first.  This was not required in v3.0.x,
so it should not have become a requirement in v3.1.

To fix this issue, dependencies are now stored as lazy callbacks.  So
long as muxjs is loaded before Shaka Player tries to play TS content,
it no longer matters when they each were loaded into the page.  This
restores the v3.0.x behavior without breaking the dependency-injection
system or its API.

Closes #3407

Change-Id: Ia6e0a68bea88f0cdb614e8751edc70147bc67f28
2021-05-14 10:00:59 -07:00
Joey Parrish 7544670ee5 chore: Upgrade eslint
The new eslint found many style errors which have now been corrected.

It also complains a lot about atomic update issues that do not seem to
exist, so that rule has been disabled.

This upgrade will allow us to adopt eslint's "id-denylist" instead of
the older "id-blacklist" rule, the name of which violates new Google
guidelines about respectful language.

Bug: 178203011

Change-Id: Ia65581b96e4dd1331f720fa396183dca020b9caf
2021-02-01 23:36:12 +00:00
Sergei Gridasov d477326e3d feat: add dependencies module (#2683)
Closes #2562
2020-08-05 11:11:32 -07:00