Commit Graph

7 Commits

Author SHA1 Message Date
Álvaro Velad Galván 3b2f7dba04 Fix(UI): Stop using setAttribute for ARIA (#3489)
* Stop using setAttribute for ARIA
* Remove references to shaka.ui.Constants.ARIA_LABEL
2021-07-07 12:30:32 -07:00
Joey Parrish f539147d48 fix: Correct license headers in compiled output
This fixes all the license headers in the main library, which corrects
the appearance of the main license in the compiled output.

It seems that the `!` in the header forces the compiler to keep it in
the output.  I believe older compiler releases did this purely based
on `@license`.

Issue #2638

Change-Id: I7f0e918caad10c9af689c9d07672b7fe9be7b2f3
2020-06-09 16:05:09 -07:00
Joey Parrish a955d9f189 Fix UI keyboard Event types
The latest Closure Compiler is more picky about Event types, and
complained about the use of "key" on Event.  This updates the Event
types so that the compiler has the correct type info.

This also stops using "keyCode", which is deprecated, and only uses
the current "key" property, which is even supported on IE, and should
not create any compatibility issues.

Issue #2528

Change-Id: Ic565772b1cc9597e358df015a73c40ac245edd6a
2020-04-28 21:41:02 +00:00
Joey Parrish 64896d70b0 Use shorter license header
This reflects changes in Google's policy on JavaScript license
headers, which should be smaller to avoid increasing the size of the
binary unnecessarily.

This also updates the company name from "Google, Inc" to "Google LLC".

Change-Id: I3f8b9ed3700b6351f43173d50c94d35c333e82b4
2019-11-22 18:18:36 +00:00
Joey Parrish bc1c3fd012 Make seek & volume bar colors configurable
The seek bar and volume bar are both styled with CSS linear gradients
which are constructed at runtime using the player & video state.  This
makes their styles impossible to tweak in pure CSS.  Before this
change, to maintain the same gradient with different colors, an
application would have to replicate our JS logic.

Now, the application can configure the colors without replicating the
logic used to construct the gradient.

Fixes #2203

Change-Id: I22e62de6c436241e141c76557ebf950cfc8b3ff5
2019-10-22 08:31:01 +00:00
Michelle Zhuo 3bde775c53 UI A11y: Make navigation stay inside overflow menu
When using keyboard to navigate through the overlfow menus, make sure
the focus stays inside the overflow menu, and do not let the user select
the elements behind the overflow menu until the user exits it.

Issue #1686

Change-Id: I4abdebb6b6bee9899dcc5f3144a2806addf08f0a
2019-02-05 22:06:46 +00:00
Sandra Lokshina 121b615c3e Break UI into components design.
What's already done:
- UIElement and IUIElement interface
- All elements register themselves with controls
- Each element is responsible for its' behavior
- A bit of clean up with constants/enums moving to
their own files

What is not done yet:
- Overflow menu is a dumping ground now. Its'
elements will move to the UIElement model eventually, too.
- Build files are hacked a bit and will need more attention.
- No clean up has been done except for the constants/enums.

Change-Id: I9917aa705e85158a2f26830bd988552fe177e53b
2019-01-17 21:58:12 +00:00