This corrects/normalizes license headers in misc. files, such as
config files, docs, build tools, tests, and externs. This does not
affect the compiled output, and is only done for consistency.
Issue #2638
Change-Id: I9d8da2de55243b08d7df2b743aac73c6f15e858a
We used to alias static utility methods by assigning the method itself
to a local variable. This is not allowed by the new Closure Compiler
release that we are adopting, and for good reason.
The old compiler did not understand the use of "this" in static
methods, but the new one does. And it turns out that when we start
using "this" in static methods (see #2532), aliasing the method itself
can break everything.
When you refer to "this" in a static method, it refers to the class.
This is really useful in utility classes that have private static
methods they use to perform common tasks. However, just as it ruins
the value of "this" to alias an instance method, the same is true of
an ES6 class's static method.
The fix is to always alias the class instead of the method. The new
compiler will simply not let us get away with the old way any more, so
regressions after this are unlikely.
Issue #2528 (compiler upgrade)
Issue #2532 (static "this")
Change-Id: Id800d466e639c7cbcf4aa6fbb05114c772a2229f
These tests have been broken since the refactor of our demo asset
objects. The new Asset class changed some of the types of its
members, but offered methods to configure Player and NetworkingEngine.
The external playback tests were never updated to match, and so fail
for any encrypted asset or any asset using network filters.
This affects both v2.5.x and the master branch leading up to v2.6.
Change-Id: Ia3751d7fc83387bc1565e69ac8d2ed32564804cb
This changes the eslint rule to enforce a strict pattern for the
argument comments. The comment must appear before the argument and
must be /* foo= */. This still ignores line comments.
Change-Id: I3afb01c65e1088eda13facb3aeeaa7595a2f5aee
This method should probably never have been in the library, since it
creates a fixed-sized, muted element.
Change-Id: I53b474305465bef34d43ce40ec5e7dedceb20a25
This reflects changes in Google's policy on JavaScript license
headers, which should be smaller to avoid increasing the size of the
binary unnecessarily.
This also updates the company name from "Google, Inc" to "Google LLC".
Change-Id: I3f8b9ed3700b6351f43173d50c94d35c333e82b4
This is not run regularly or by default, and many things about it were
broken since the last time we paid attention to it.
The DRM checks were broken in the demo app refactor for v2.5, and
other parts were broken for even longer.
Change-Id: I053f2615a749e7e7d6252f689d16c50b99cf94ff
This ensures that we get the expected types and that type coercion
doesn't convert between types. This also ensures we are consistent
in how we check for equality of primitives in tests.
Change-Id: I9f3aacdf25ab1afe5e8d6e4b895b5299ee687d54
This also removes the unused SimpleIDB type and removes the duplicate
code in Utils that appears in Waiter.
Issue #1157
Change-Id: Ib3cfc16212b9d169b360825a25a084c5ebd7b80f
With the new style rule, we cannot have two statements on the same line.
So we can no longer have an "if" on a single line and we cannot have
an arrow function with a body on the same line as when it is used.
This is mostly a manual change.
Change-Id: I2285202dd5ecbad764308bc725e6d317ff2ee7f0
A coming update to the Google eslint config will require using "const"
over "let". This makes that one change to isolate the big changes.
Change-Id: I7d0974c3ae15c53cc45a6b07bf9f6586e2d34aca
This is a complete replacement for the old demo page, made to be more
modern-looking and easier to maintain. It contains new features such as
remembering the URIs you provide for custom assets, and searching through
the default assets by feature.
This demo page is not quite ready for release yet, but it's getting close.
Change-Id: Iad01d1fc02c3cd238d73b9b9e02dbb4301cb6f2a
There is a workaround for a Tizen bug which appears in many of our
test suites. To avoid having to add this to yet more, this change
factors out the workaround such that it applies to all tests.
Change-Id: Ie34c81bfcac94310bf3cd021fd4f2d55905b647a
The integration tests for src= failed almost universally on Tizen, but
a few failed on other platforms, as well. The issue was the fixed
delays in those tests. This replaces those fixed delays with an
event-based utility that solved the same problem in other Player
integration tests.
Issue #816
Issue #997
Change-Id: Ib43cbb139ef77be1219e60d1fd5009aa403cc4cb
We often use the IDestroyable interface to provide us with a standardized
way to break internal references and tear-down objects, however many
objects don't need this to be async. Once using IDestroyable, everyone
must assume that you must be async.
This change introduces IReleasable, a sibling to IDestryable, which
provides the |release| method. IReleasable is the synchronous version of
IDestroyable.
This change converts EventManager from IDestroyable to IReleasable as
the first of many conversions.
Change-Id: Ic3e90e594abc1c7326eccbe2521eb71676b74a09
This fixes several sources of flake in the external asset tests:
- Network-based flake, introduced when the NetworkInfo API gave us
a non-hard-coded default bandwidth estimate and when crossing
period boundaries
- End detection, in which we see varying behavior across browsers
and must be more forgiving in our expectations
- Start detection, in which some hardware platforms (Chromecast)
take longer to start playback than we might guess
- Gaps, in which some platforms (Safari, Firefox) get stuck in gaps
that other platforms do not
Bug: 28087927
Pre-work for issue #1597
Change-Id: I2516dfac176e67eefd13983944280764c057ab89
Now, unit tests will not be served when running a custom asset test.
This makes the results saner, showing only the one custom asset test
instead of showing 1300+ skipped tests.
Custom asset test flags will also implicitly cause the relevant test
files to be served, rather than requiring --external as well.
Change-Id: I117c3fa90ab16bd059530ab716a17d2462906419
This replaces almost every instance of indexOf on both String and
Array. There are very few places where we really wanted an index.
Mostly, indexOf was used to check for inclusion.
Change-Id: I08e299768b6ffdb4bfc30b39b5d82a058c6d1b56
By splitting out external asset tests into a separate file, we can
instruct karma to load them only when they will be run. This reduces
the number of "skipped" tests that show up in our test runs.
Ultimately, this can help us identify tests that are being skipped on
accident, so that we can fix our nightly test infrastructure.
Change-Id: Iac27ec07ff7e814824158b3e1821111a3f5a136d
Joey Parrish
Jacob Trimble
Theodore Abshire
Sandra Lokshina
Aaron Vaage