Commit Graph

18 Commits

Author SHA1 Message Date
Álvaro Velad Galván e39defb6f7 feat(Ads): Remove circular dependency (#6868)
To eliminate `* @suppress {missingRequire}` it was necessary to create a
new class with the constants and deprecate the old ones. That's why this
change is feat.
2024-06-20 07:51:58 +02:00
Thomas Champion 8f0db8e89d fix: add missing properties to PlayButton type (#6130)
Fixes https://github.com/shaka-project/shaka-player/issues/6125.
2024-01-22 08:23:26 +01:00
Álvaro Velad Galván 6b7a02ae91 fix(UI): Fix replay button when the post-roll is running using CS (#6072) 2024-01-10 17:31:15 +01:00
Álvaro Velad Galván 9c3bed3d60 feat(ads): Integrate with non-linear IMA CS ads (#3639)
Closes: #2596
2021-10-18 11:42:54 -07:00
Álvaro Velad Galván 8b418bb13c Fix(UI): Update Play icon after seeking from end (#3515)
We change the "play" button icon to become "rewind" when the video ends.
However, previously we did not update the icon again when seeking.
This would lead to the icon still looking like a "rewind" button if
the user seeks back from the end of the video.
This fixes that, by making the button listen to "seeking" events.
2021-07-10 02:46:00 -07:00
Álvaro Velad Galván 2dedd9f3f5 Fix: Fix ARIA label on replay button (#3513)
Close: #3512
2021-07-08 15:17:16 -07:00
Álvaro Velad Galván 3b2f7dba04 Fix(UI): Stop using setAttribute for ARIA (#3489)
* Stop using setAttribute for ARIA
* Remove references to shaka.ui.Constants.ARIA_LABEL
2021-07-07 12:30:32 -07:00
Theodore Abshire 655493f441 Fix(ads): Fix bug w/ configuring UI during CS ads
Previously, the client-side ad container was put inside the controls
container, which was cleared when the UI was configured. This meant
that re-configuring the UI made client-side ads go away, basically.
This moves client-side ads to go into their own container, which
is never re-made or uprooted, even when the DOM is recreated, in
order to not break the IMA SDK.
This has the side-effect of fixing a bug where client-side ads were
not always cleared upon loading a new asset, and could show up
unexpectedly in future playbacks.

Fixes #2869
Fixes #2943

Change-Id: I3cf67b0b278764c10c6ff2f678316dc9cc85929e
2020-12-16 14:26:09 -08:00
Theodore Abshire 67a49d45e3 cleanup: Add missing requires.
This is a port of the internal changes: cl/329816039

Change-Id: If162e80e107ef7dc40956d6f4160d24f6d50858d
2020-09-14 22:50:49 +00:00
Joey Parrish 2d4f36f509 fix: Add missing require statements
Caught by a newer compiler

Change-Id: I27a392b35302cce0817c2e95cd25584df4c2b58d
2020-08-25 16:30:53 -07:00
Joey Parrish f539147d48 fix: Correct license headers in compiled output
This fixes all the license headers in the main library, which corrects
the appearance of the main license in the compiled output.

It seems that the `!` in the header forces the compiler to keep it in
the output.  I believe older compiler releases did this purely based
on `@license`.

Issue #2638

Change-Id: I7f0e918caad10c9af689c9d07672b7fe9be7b2f3
2020-06-09 16:05:09 -07:00
Joey Parrish c1d849bc9b Fix UI button types
The compiler is very picky about the use of the "disabled" property on
HTMLElement, since it is only defined on certain subclasses of that.
This adds a method to create a button with the correct type to satisfy
the compiler.

Issue #2528

Change-Id: I31cacd62a35acc87b245ab362dbab55d791cf34d
2020-04-28 21:40:53 +00:00
Joey Parrish 64896d70b0 Use shorter license header
This reflects changes in Google's policy on JavaScript license
headers, which should be smaller to avoid increasing the size of the
binary unnecessarily.

This also updates the company name from "Google, Inc" to "Google LLC".

Change-Id: I3f8b9ed3700b6351f43173d50c94d35c333e82b4
2019-11-22 18:18:36 +00:00
Sandra Lokshina 47c857d100 Make it possible to exclude ads from the build.
Closes #2231

Change-Id: I3ef4ce09fa3a08bfcaffa2d53aae4bbec70b33c1
2019-11-14 18:13:55 +00:00
Sandra Lokshina 0f6e973589 Play/pause the current ad on video container click.
Similar to how we play/pause the presentation in
this case.

Issue #2222.

Change-Id: I58944afb49159e3dc8bd6b16b930f13b9556f25f
2019-11-04 20:29:44 +00:00
Sandra Lokshina d47362ac5e Integrate play button icon change with ads and fix fade out.
1) Play buttons' icons now toggle between play and pause
depending on ad state during ad playback.

2) Controls fade in and out on mouse out/in during
ad playback similar to how they do it during the
presentation.

Issue #2222.

Change-Id: I97ce3b5aa70bdfdd758a54894a3d94b38bccf953
2019-11-01 14:02:19 -07:00
Sandra Lokshina 688d8881d9 Change controls behavior when an ad is playing.
This CL makes the controls switch between controlling
the ad and the presentation. If there's an ad currently
playing, pause button will pause the ad instead of the
presentation, mute button will mute the ad, etc.

Change-Id: I42f57df9a5ce491ed842f39e0f1e6031d1e3a93c
2019-11-01 16:25:52 +00:00
Sandra Lokshina 635acb6ecf Extract the big play button into its own class & make it optional.
Change-Id: I462632c3da5f8ff5a68e111940591086bb395a13
2019-07-25 22:06:37 +00:00