Now that we are building tools to keep common workflows in sync across
repos, we should use the same names across repos. This brings Shaka
Player workflow names in line with everything else.
See https://github.com/joeyparrish/shaka-github-tools/pull/5
1. When release-please creates release PRs, it removes the -uncompiled
tag in the version number in lib/player.js. This adds a step to the
workflow to maintain the player.js version manually.
2. This also adds a new job that tags the master branch after a
release PR is merged. We maintain the -master tags on the master
branch corresponding to each release so that it is easier to manage
the range of commits for cherry-picks.
3. The "npm ci" step was failing because our package-lock.json was not
compatible with v12 of NodeJS. This updates our workflow to use v16.
The npm release workflow has now been tested in a fork up until the
publish step.
4. The tagging and GitHub release publication parts of the workflow
were previously failing due to an issue with release-please parsing
the branch name. This has now been fixed, and is awaiting an upstream
merge. For now, we can use my forked version.
Closes#3968 (branch parsing failure)
Issue #3969 (npm release is now tested up to the publish step)
Closes#3971 (master branch tags)
Closes#3974 (missing -uncompiled in lib/player.js)
The old template is bulky and does not reflect the new workflows we
have on GitHub. All that is really critical is that users start using
Conventional Commits syntax and tag issue numbers.
Force-pushes from automated PRs (like release-please) do not seem to
trigger any of the normal PR triggers (opened, edited, synchronize).
In fact, even an exhaustive list of types will not work. So here we
add triggers for reviews, so that the validation will run after
someone approves such a PR. This is critical since this is a required
status check in most of our repos. If the workflow doesn't run, the
release PR can't be merged.
This includes a temporary config file to bootstrap the workflow for
the master branch, whose commit and branch history is too confusing
for the tool to handle with defaults. After v3.4.0 is released from
the master branch, these configs can be deleted.
CI for Firefox on Linux is failing because of (I suspect) an outdated
package index in Ubuntu. This addresses it by updating the package
list before installing ffmpeg.
Issue templates can set labels automatically on new issues. We
already did this for questions, but not for bugs or features.
Now the label name for questions has changed, and needed to be
updated. Also, for our new triage process, it is helpful to set bug
and enhancement labels automatically.
Change-Id: I28f79f0b5984709b117965c692e1e3aa774abb31
- Puts the description info in a comment.
- Adds comments to screenshots section.
- Removes the comments telling people to remove checkbox lines.
- Adds new checklist items for CLA/build/test.
Change-Id: I2d3b66c9b1a16eb489f8d65526a17c4ad4e4fae9
It makes it easier to debug if we know the app's configuration settings.
This adds a section to ask for that in the bug template.
Change-Id: I18ec8822165c24b9ee655f2a18df6f569c39607b
We're getting more questions, and some of the answers are covered in the
tutorial and API docs.
Adding a link to the tutorials page, to encourage people to check the
tutorial before asking a question.
Change-Id: I3d04938666e1c9fa818146517018aa7334c022b7
Previously, the issue template for questions did not contain any
actual template.
We were getting a lot of "questions" that should have been filed as
bugs or feature requests instead.
This adds more to the question template, to encourage people to file the
correct template, and to get them to add at least some details.
Change-Id: I2c82ec46eae96fb33df5b97185e46708444ce7fa
https://goo.gl is being turned-down, so we can't use it for new URLS.
So we have consistent short links, this converts them to be
https://bit.ly.
Change-Id: I07a86cba807b67157664893341f648023918d0de
Many people either ignore the template or fail to send us the URIs we
need for repro. This adds language making it clear what we need.
Change-Id: I4da8d0dd7d7a203e71e5cc6c55b99e2f27e8d642
The FAQ file had to be moved into the tutorials folder to make this
work for some reason. JSDoc did not want to take "../faq" as a name.
Closes#865
Change-Id: I63ff5b181f494d72c04eaa054111d9fdc866064c
Joey Parrish
Shaka Bot
theodab
Joey Parrish
Jacob Trimble
Arijit Kundu
Akash Gupta
michellezhuo