mirror of
https://github.com/shaka-project/shaka-player.git
synced 2026-06-26 17:46:26 +03:00
Joey Parrish
45a1d71b8a
This adds extra conformance checks:
- A ban on @expose, which we already got rid of in 775d7552
- A ban on unresolved types, which did not generate any failures
- A ban on global variables
- A more comprehensive ban on console logging
None of these caught any real bugs in the existing code base.
In one test suite (MediaSourceEngine unit tests), the compiler was
unable to determine the type of one of the mocks, leading it to
suspect that it could possibly violate the new ban on console.error.
The goog.define('GIT_VERSION', ...) line in player.js was seen
(correctly) as a global variable. This has been fixed and simplified
as a result.
The only custom conformance checks we are not using are "BanNullDeref"
(too many false negatives) and "BanThrowOfNonErrorTypes" (for which
we have our own, more restrictive version).
Since we have now tried all custom conformance rules provided by the
compiler today, this closes the associated issue.
Closes #1130.
Change-Id: Iad9040d0f5ee397c7d46b1d64bc5bebf2def57bc
83 lines
2.5 KiB
Python
Executable File
83 lines
2.5 KiB
Python
Executable File
#!/usr/bin/env python
|
|
#
|
|
# Copyright 2016 Google Inc. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
"""Checks that all the versions match."""
|
|
|
|
import logging
|
|
import os
|
|
import re
|
|
|
|
import shakaBuildHelpers
|
|
|
|
|
|
def player_version():
|
|
"""Gets the version of the library from player.js."""
|
|
path = os.path.join(shakaBuildHelpers.get_source_base(), 'lib', 'player.js')
|
|
with open(path, 'r') as f:
|
|
match = re.search(r'shaka\.Player\.version = \'(.*)\'', f.read())
|
|
return match.group(1) if match else ''
|
|
|
|
|
|
def changelog_version():
|
|
"""Gets the version of the library from the CHANGELOG."""
|
|
path = os.path.join(shakaBuildHelpers.get_source_base(), 'CHANGELOG.md')
|
|
with open(path, 'r') as f:
|
|
match = re.search(r'## (.*) \(', f.read())
|
|
return match.group(1) if match else ''
|
|
|
|
|
|
def check_version(_):
|
|
"""Checks that all the versions in the library match."""
|
|
changelog = changelog_version()
|
|
player = player_version()
|
|
git = shakaBuildHelpers.git_version()
|
|
npm = shakaBuildHelpers.npm_version()
|
|
|
|
print 'git version:', git
|
|
print 'npm version:', npm
|
|
print 'player version:', player
|
|
print 'changelog version:', changelog
|
|
|
|
ret = 0
|
|
if 'dirty' in git:
|
|
logging.error('Git version is dirty.')
|
|
ret = 1
|
|
elif 'unknown' in git:
|
|
logging.error('Git version is not a tag.')
|
|
ret = 1
|
|
elif not re.match(r'^v[0-9]+\.[0-9]+\.[0-9]+(?:-[a-z0-9]+)?$', git):
|
|
logging.error('Git version is a malformed release version.')
|
|
logging.error('It should be a \'v\', followed by three numbers')
|
|
logging.error('separated by dots, optionally followed by a hyphen')
|
|
logging.error('and a pre-release identifier. See http://semver.org/')
|
|
ret = 1
|
|
|
|
if 'v' + npm != git:
|
|
logging.error('NPM version does not match git version.')
|
|
ret = 1
|
|
if player != git + '-uncompiled':
|
|
logging.error('Player version does not match git version.')
|
|
ret = 1
|
|
if 'v' + changelog != git:
|
|
logging.error('Changelog version does not match git version.')
|
|
ret = 1
|
|
|
|
return ret
|
|
|
|
|
|
if __name__ == '__main__':
|
|
shakaBuildHelpers.run_main(check_version)
|