mirror of
https://github.com/shaka-project/shaka-player.git
synced 2026-06-16 16:16:40 +03:00
655493f441
Previously, the client-side ad container was put inside the controls container, which was cleared when the UI was configured. This meant that re-configuring the UI made client-side ads go away, basically. This moves client-side ads to go into their own container, which is never re-made or uprooted, even when the DOM is recreated, in order to not break the IMA SDK. This has the side-effect of fixing a bug where client-side ads were not always cleared upon loading a new asset, and could show up unexpectedly in future playbacks. Fixes #2869 Fixes #2943 Change-Id: I3cf67b0b278764c10c6ff2f678316dc9cc85929e