mirror of
https://github.com/shaka-project/shaka-player.git
synced 2026-06-16 16:16:40 +03:00
6c85c8cbfc
TTML nested cues are meant to be displayed horizontally as inline elements. This fixes the rendering of these nested cues in both SimpleTextDisplayer and UITextDisplayer. In UITextDisplayer, the styles have been adjusted to lay out the nested cues horizontally rather than vertically. In SimpleTextDisplayer, the nested cues were being displayed as if they were top-level cues. This change concatenates the nested cues into a single cue displayed in the browser. This also improves comments on the poorly-named "spacer" property, which represents a line break in TTML. This fixes the rendering of "spacer" in SimpleTextDisplayer by inserting an actual newline character into the collapsed nested cues. Finally, this fixes and clarifies names used internally in UITextDisplayer. For example, there is a difference between a nested cue and leaf cue. A nested cue and a top-level cue without nested cues are both "leaf" cues, but a top-level cue is never a "nested" cue, since it is at the top level. The conflation of these names before this fix made it difficult to understand and fix the code in the first place. Closes #2760 Change-Id: I89633761d12704e253371d17e2e786c5b2ed67a7