mirror of
https://github.com/shaka-project/shaka-player.git
synced 2026-06-16 16:16:40 +03:00
5166699e10
In DASH SegmentBase, we were not dividing presentationTimeOffset by the timescale. In all other instances of presentationTimeOffset in DASH, we were handling it correctly. This bug was present in all v2 releases until now. The solution is not only to divide by timescale, but to rename all internal uses of presentationTimeOffset to either unscaled or scaled, to differentiate between those in timescale units and those in seconds. I believe inconsistent naming and units were a contributing factor to the creation of the bug. Closes #1099 Change-Id: Id561f8eb1f5bc011c606e1925c12f0d8183fd51a