shaka-player

mirror of https://github.com/shaka-project/shaka-player.git synced 2026-06-26 17:46:26 +03:00

Files

T

Theodore Abshire 697a565051 Change positioning of line-positioned subtitles.

Previously, we were positioning subtitles relative to the video,
but this lead to problems with subtitles that were manually positioned
(via the line attribute) to be low (85% or lower); they would overlap
with the controls bar, and thus be hidden.

This changes cues to be positioned relative to the text-usable area of
the screen (e.g. the space above the controls bar). In addition, the
less values have been changed to not trim cues that extend out of the
container, so that if they do overlap with the controls, they aren't
clipped in an ugly way.
Examining the Chrome native controls, this appears to be closer to how
they render captions.

Fixes #2524

Change-Id: I4500b8f637f3f43f48d019d14ef527e75d960fec

2020-05-01 20:31:55 +00:00

ad_controls.less

Replace our skip button with the IMA's default one.

2020-04-22 21:03:11 +00:00

buttons.less

Use short license in more files.

2020-02-11 19:09:44 +00:00

containers.less

Change positioning of line-positioned subtitles.

2020-05-01 20:31:55 +00:00

general.less

Use short license in more files.