mirror of
https://github.com/shaka-project/shaka-player.git
synced 2026-06-18 16:36:56 +03:00
cdeffbb9e6
First, the positioning of cues was incorrect. We need to explicitly set all the position attributes when we position elements with the "absolute" position. Second, if we position a text <span> manually, the background will fill the whole region. So to keep the background wrapping the text, we need to add another <span> for the text. Third, the background and font color should not be set on every <span> element since it won't allow parent cues to set the inherited value. So this moves the defaults to the top-level text element and allows parent cue elements to override this. It also would make app CSS easier to override. Because background color isn't inherited through CSS, the default is set in JavaScript instead. Fixes #3521 Fixes #3600 Closes #3713 Change-Id: I45fc88dcac4a0a062e1474087f24c80d98eef619