contrib/fasthttp
1
0
Fork 0
mirror of https://github.com/valyala/fasthttp.git synced 2026-06-14 15:56:44 +03:00
Code Issues Packages Projects Releases Wiki Activity

Avoid nolint:errcheck in header tests (#1589)

Browse Source
This commit is contained in:
Oleksandr Redko
2023-07-06 10:11:45 +03:00
committed by GitHub
parent 0d0bbfee5a
commit 064124ec85
1 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
header_test.go
+19 -7
View File
@@ -26,7 +26,9 @@ func TestResponseHeaderAddContentType(t *testing.T) {
}
var buf bytes.Buffer
h.WriteTo(&buf) //nolint:errcheck
if _, err := h.WriteTo(&buf); err != nil {
t.Fatalf("unexpected error when writing header: %v", err)
}
if n := strings.Count(buf.String(), "Content-Type: "); n != 1 {
t.Errorf("Content-Type occurred %d times", n)
@@ -46,7 +48,9 @@ func TestResponseHeaderAddContentEncoding(t *testing.T) {
}
var buf bytes.Buffer
h.WriteTo(&buf) //nolint:errcheck
if _, err := h.WriteTo(&buf); err != nil {
t.Fatalf("unexpected error when writing header: %v", err)
}
if n := strings.Count(buf.String(), "Content-Encoding: "); n != 1 {
t.Errorf("Content-Encoding occurred %d times", n)
@@ -138,13 +142,15 @@ func TestResponseHeaderMultiLineName(t *testing.T) {
}
}
func TestResponseHeaderMultiLinePaniced(t *testing.T) {
func TestResponseHeaderMultiLinePanicked(t *testing.T) {
t.Parallel()
// Input generated by fuzz testing that caused the parser to panic.
s, _ := base64.StdEncoding.DecodeString("aAEAIDoKKDoKICA6CgkKCiA6CiA6CgkpCiA6CiA6CiA6Cig6CiAgOgoJCgogOgogOgoJKQogOgogOgogOgogOgogOgoJOg86CiA6CiA6Cig6CiAyCg==")
header := new(RequestHeader)
header.parse(s) //nolint:errcheck
if _, err := header.parse(s); err == nil {
t.Error("expected error, got <nil>")
}
}
func TestResponseHeaderEmptyValueFromHeader(t *testing.T) {
@@ -3021,7 +3027,9 @@ func TestAddVaryHeader(t *testing.T) {
}
var buf bytes.Buffer
h.WriteTo(&buf) //nolint:errcheck
if _, err := h.WriteTo(&buf); err != nil {
t.Fatalf("unexpected error when writing header: %v", err)
}
if n := strings.Count(buf.String(), "Vary: "); n != 1 {
t.Errorf("Vary occurred %d times", n)
@@ -3042,7 +3050,9 @@ func TestAddVaryHeaderExisting(t *testing.T) {
}
var buf bytes.Buffer
h.WriteTo(&buf) //nolint:errcheck
if _, err := h.WriteTo(&buf); err != nil {
t.Fatalf("unexpected error when writing header: %v", err)
}
if n := strings.Count(buf.String(), "Vary: "); n != 1 {
t.Errorf("Vary occurred %d times", n)
@@ -3063,7 +3073,9 @@ func TestAddVaryHeaderExistingAcceptEncoding(t *testing.T) {
}
var buf bytes.Buffer
h.WriteTo(&buf) //nolint:errcheck
if _, err := h.WriteTo(&buf); err != nil {
t.Fatalf("unexpected error when writing header: %v", err)
}
if n := strings.Count(buf.String(), "Vary: "); n != 1 {
t.Errorf("Vary occurred %d times", n)