contrib/fasthttp
1
0
Fork 0
mirror of https://github.com/valyala/fasthttp.git synced 2026-06-14 15:56:44 +03:00
Code Issues Packages Projects Releases Wiki Activity

When StreamRequestBody is set to true, we cannot safely release br. (#1844)

Browse Source 
For example, when using chunked encoding, it's possible that `br` has only read the request headers.
This commit is contained in:
newacorn
2024-08-31 20:41:54 +08:00
committed by GitHub
parent 3aa972e2fc
commit d31f4ef7d5
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server.go
+4 -3
View File
@@ -2286,8 +2286,9 @@ func (s *Server) serveConn(c net.Conn) (err error) {
err = ctx.Request.readLimitBody(br, maxRequestBodySize, s.GetOnly, !s.DisablePreParseMultipartForm)
}
}
if (s.ReduceMemoryUsage && br.Buffered() == 0) || err != nil {
// When StreamRequestBody is set to true, we cannot safely release br.
// For example, when using chunked encoding, it's possible that br has only read the request headers.
if (!s.StreamRequestBody && s.ReduceMemoryUsage && br.Buffered() == 0) || err != nil {
releaseReader(s, br)
br = nil
}
@@ -2358,7 +2359,7 @@ func (s *Server) serveConn(c net.Conn) (err error) {
} else {
err = ctx.Request.ContinueReadBody(br, maxRequestBodySize, !s.DisablePreParseMultipartForm)
}
if (s.ReduceMemoryUsage && br.Buffered() == 0) || err != nil {
if (!s.StreamRequestBody && s.ReduceMemoryUsage && br.Buffered() == 0) || err != nil {
releaseReader(s, br)
br = nil
}