contrib/openrtb
1
0
Fork 0
mirror of https://github.com/prebid/openrtb.git synced 2026-06-14 14:06:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

adcom1: review numeric types - use fixed-size int/uint

Browse Source
This commit is contained in:
Max Cherry
2018-12-28 12:56:48 +02:00
parent e16d59dbc8
commit 8f16e4006d
12 changed files with 29 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
adcom1/asset.go
+1 -1
View File
@@ -11,7 +11,7 @@ type Asset struct {
// integer
// Definition:
// The value of AssetFormat.id if this ad references a specific native placement defined by a Placement object and its structure.
ID int `json:"id,omitempty"`
ID int64 `json:"id,omitempty"`
// Attribute:
// req
adcom1/asset_format.go
+1 -1
View File
@@ -12,7 +12,7 @@ type AssetFormat struct {
// integer; required
// Definition:
// Asset ID, unique within the scope of this placement specification.
ID int `json:"id"`
ID int64 `json:"id"`
// Attribute:
// req
adcom1/content.go
+1 -1
View File
@@ -20,7 +20,7 @@ type Content struct {
// integer
// Definition:
// Episode number.
Episode int `json:"episode,omitempty"`
Episode uint16 `json:"episode,omitempty"`
// Attribute:
// title
adcom1/device.go
+3 -3
View File
@@ -95,7 +95,7 @@ type Device struct {
// integer
// Definition:
// Physical height of the screen in pixels.
H int `json:"h,omitempty"`
H uint64 `json:"h,omitempty"`
// Attribute:
// w
@@ -103,7 +103,7 @@ type Device struct {
// integer
// Definition:
// Physical width of the screen in pixels.
W int `json:"w,omitempty"`
W uint64 `json:"w,omitempty"`
// Attribute:
// ppi
@@ -111,7 +111,7 @@ type Device struct {
// integer
// Definition:
// Screen size as pixels per linear inch.
PPI int `json:"ppi,omitempty"`
PPI uint16 `json:"ppi,omitempty"`
// Attribute:
// pxratio
adcom1/display.go
+4 -4
View File
@@ -40,7 +40,7 @@ type Display struct {
// Definition:
// Absolute width of the creative in device independent pixels (DIPS), typically for non-native ads.
// Note that mixing absolute and relative sizes is not recommended.
W int `json:"w,omitempty"`
W uint64 `json:"w,omitempty"`
// Attribute:
// h
@@ -49,7 +49,7 @@ type Display struct {
// Definition:
// Absolute height of the creative in device independent pixels (DIPS), typically for non-native ads.
// Note that mixing absolute and relative sizes is not recommended.
H int `json:"h,omitempty"`
H uint64 `json:"h,omitempty"`
// Attribute:
// wratio
@@ -58,7 +58,7 @@ type Display struct {
// Definition:
// Relative width of the creative when expressing size as a ratio, typically for non-native ads.
// Note that mixing absolute and relative sizes is not recommended.
WRatio int `json:"wratio,omitempty"`
WRatio uint64 `json:"wratio,omitempty"`
// Attribute:
// hratio
@@ -67,7 +67,7 @@ type Display struct {
// Definition:
// Relative height of the creative when expressing size as a ratio, typically for non-native ads.
// Note that mixing absolute and relative sizes is not recommended.
HRatio int `json:"hratio,omitempty"`
HRatio uint64 `json:"hratio,omitempty"`
// Attribute:
// priv
adcom1/display_format.go
+4 -4
View File
@@ -11,7 +11,7 @@ type DisplayFormat struct {
// Definition:
// Absolute width of the creative in units specified by DisplayPlacement.unit.
// Note that mixing absolute and relative sizes is not recommended.
W int `json:"w,omitempty"`
W uint64 `json:"w,omitempty"`
// Attribute:
// h
@@ -20,7 +20,7 @@ type DisplayFormat struct {
// Definition:
// Absolute height of the creative in units specified by DisplayPlacement.unit.
// Note that mixing absolute and relative sizes is not recommended.
H int `json:"h,omitempty"`
H uint64 `json:"h,omitempty"`
// Attribute:
// wratio
@@ -29,7 +29,7 @@ type DisplayFormat struct {
// Definition:
// Relative width of the creative when expressing size as a ratio.
// Note that mixing absolute and relative sizes is not recommended.
WRatio int `json:"wratio,omitempty"`
WRatio uint64 `json:"wratio,omitempty"`
// Attribute:
// hratio
@@ -38,7 +38,7 @@ type DisplayFormat struct {
// Definition:
// Relative height of the creative when expressing size as a ratio.
// Note that mixing absolute and relative sizes is not recommended.
HRatio int `json:"hratio,omitempty"`
HRatio uint64 `json:"hratio,omitempty"`
// Attribute:
// expdir
adcom1/display_placement.go
+2 -2
View File
@@ -110,7 +110,7 @@ type DisplayPlacement struct {
// Definition:
// Width of the placement in units specified by unit.
// Note that this size applies to the placement itself; permitted creative sizes are specified elsewhere (e.g., DisplayFormat, ImageAssetFormat, etc.).
W int `json:"w,omitempty"`
W uint64 `json:"w,omitempty"`
// Attribute:
// h
@@ -119,7 +119,7 @@ type DisplayPlacement struct {
// Definition:
// Width of the placement in units specified by unit.
// Note that this size applies to the placement itself; permitted creative sizes are specified elsewhere (e.g., DisplayFormat, ImageAssetFormat, etc.).
H int `json:"h,omitempty"`
H uint64 `json:"h,omitempty"`
// Attribute:
// unit
adcom1/dooh.go
+1 -1
View File
@@ -38,7 +38,7 @@ type DOOH struct {
// integer
// Definition:
// Minimum DPI for text-based creative elements to display clearly.
DPI int `json:"dpi,omitempty"`
DPI uint16 `json:"dpi,omitempty"`
// Attribute:
// ext
adcom1/geo.go
+2 -2
View File
@@ -42,7 +42,7 @@ type Geo struct {
// Estimated location accuracy in meters; recommended when lat/lon are specified and derived from a device's location services (i.e., type = 1).
// Note that this is the accuracy as reported from the device.
// Consult OS specific documentation (e.g., Android, iOS) for exact interpretation.
Accur int `json:"accur,omitempty"`
Accur int64 `json:"accur,omitempty"`
// Attribute:
// lastfix
@@ -113,7 +113,7 @@ type Geo struct {
// integer
// Definition:
// Local time as the number +/- of minutes from UTC.
UTCOffset int `json:"utcoffset,omitempty"`
UTCOffset int64 `json:"utcoffset,omitempty"`
// Attribute:
// ext
adcom1/image_asset.go
+2 -2
View File
@@ -19,7 +19,7 @@ type ImageAsset struct {
// integer; recommended
// Definition:
// Width of the image asset in device independent pixels (DIPS).
W int `json:"w,omitempty"`
W uint64 `json:"w,omitempty"`
// Attribute:
// h
@@ -27,7 +27,7 @@ type ImageAsset struct {
// integer; recommended
// Definition:
// Height of the image asset in device independent pixels (DIPS).
H int `json:"h,omitempty"`
H uint64 `json:"h,omitempty"`
// Attribute:
// type
adcom1/image_asset_format.go
+6 -6
View File
@@ -30,7 +30,7 @@ type ImageAssetFormat struct {
// Definition:
// Absolute width of the image asset in device independent pixels (DIPS).
// Note that mixing absolute and relative sizes is not recommended.
W int `json:"w,omitempty"`
W uint64 `json:"w,omitempty"`
// Attribute:
// h
@@ -39,7 +39,7 @@ type ImageAssetFormat struct {
// Definition:
// Absolute height of the image asset in device independent pixels (DIPS).
// Note that mixing absolute and relative sizes is not recommended.
H int `json:"h,omitempty"`
H uint64 `json:"h,omitempty"`
// Attribute:
// wmin
@@ -48,7 +48,7 @@ type ImageAssetFormat struct {
// Definition:
// The minimum requested absolute width of the image in device independent pixels (DIPS).
// This option should be used for any scaling of images by the client.
WMin int `json:"wmin,omitempty"`
WMin uint64 `json:"wmin,omitempty"`
// Attribute:
// hmin
@@ -57,7 +57,7 @@ type ImageAssetFormat struct {
// Definition:
// The minimum requested absolute height of the image in device independent pixels (DIPS).
// This option should be used for any scaling of images by the client.
HMin int `json:"hmin,omitempty"`
HMin uint64 `json:"hmin,omitempty"`
// Attribute:
// wratio
@@ -66,7 +66,7 @@ type ImageAssetFormat struct {
// Definition:
// Relative width of the image asset when expressing size as a ratio.
// Note that mixing absolute and relative sizes is not recommended.
WRatio int `json:"wratio,omitempty"`
WRatio uint64 `json:"wratio,omitempty"`
// Attribute:
// hratio
@@ -75,7 +75,7 @@ type ImageAssetFormat struct {
// Definition:
// Relative height of the image asset when expressing size as a ratio.
// Note that mixing absolute and relative sizes is not recommended.
HRatio int `json:"hratio,omitempty"`
HRatio uint64 `json:"hratio,omitempty"`
// Attribute:
// ext
adcom1/video_placement.go
+2 -2
View File
@@ -116,7 +116,7 @@ type VideoPlacement struct {
// integer
// Definition:
// Width of the placement in units specified by unit.
W int `json:"w,omitempty"`
W uint64 `json:"w,omitempty"`
// Attribute:
// h
@@ -124,7 +124,7 @@ type VideoPlacement struct {
// integer
// Definition:
// Height of the placement in units specified by unit.
H int `json:"h,omitempty"`
H uint64 `json:"h,omitempty"`
// Attribute:
// unit