Merge pull request #129 from ifunny/fix-random-node-provider

Fix RandomNodeProvider: change the max value in mt_rand() call to prevent invalid node generation

src/Provider/Node/RandomNodeProvider.php

@@ -31,6 +31,6 @@ class RandomNodeProvider implements NodeProviderInterface
      */
     public function getNode()
     {
-        return sprintf('%06x%06x', mt_rand(0, 1 << 24), mt_rand(0, 1 << 24));
+        return sprintf('%06x%06x', mt_rand(0, 0xffffff), mt_rand(0, 0xffffff));
     }
 }

tests/src/Provider/Node/RandomNodeProviderTest.php

@@ -32,7 +32,7 @@ class RandomNodeProviderTest extends TestCase
         $mtRand = AspectMock::func('Ramsey\Uuid\Provider\Node', 'mt_rand', $this->num);
         $provider = new RandomNodeProvider();
         $provider->getNode();
-        $mtRand->verifyInvokedMultipleTimes(2, [0, 1 << 24]);
+        $mtRand->verifyInvokedMultipleTimes(2, [0, 0xffffff]);
     }
 
     /**

tests/src/Provider/Time/SystemTimeProviderTest.php

@@ -29,6 +29,5 @@ class SystemTimeProviderTest extends TestCase
         $provider = new SystemTimeProvider();
         $provider->currentTime();
         $func->verifyInvokedOnce();
-
     }
 }