viaprog/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-06-13 23:36:45 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(tier): best-effort restore of data mtime on download

Browse Source 
A failed Chtimes should not abort an otherwise complete tier-down; warn
and continue, matching the EC copy path.
This commit is contained in:
Chris Lu
2026-06-13 12:48:16 -07:00
parent 8359d05ac4
commit fbfe52de6e
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
weed/server/volume_grpc_tier_download.go
+5 -2
View File
@@ -5,6 +5,7 @@ import (
"os"
"time"
"github.com/seaweedfs/seaweedfs/weed/glog"
"github.com/seaweedfs/seaweedfs/weed/pb/volume_server_pb"
"github.com/seaweedfs/seaweedfs/weed/storage/backend"
"github.com/seaweedfs/seaweedfs/weed/storage/needle"
@@ -66,8 +67,10 @@ func (vs *VolumeServer) VolumeTierMoveDatFromRemote(req *volume_server_pb.Volume
}
if remoteFileModifiedTime > 0 {
modifiedTime := time.Unix(int64(remoteFileModifiedTime), 0)
if err := os.Chtimes(v.FileName(".dat"), time.Now(), modifiedTime); err != nil {
return fmt.Errorf("restore data file %s modified time: %v", v.FileName(".dat"), err)
// best-effort: a cosmetic mtime failure should not abort an otherwise
// complete tier-down, matching the EC copy path
if err := os.Chtimes(v.FileName(".dat"), modifiedTime, modifiedTime); err != nil {
glog.Warningf("volume %d restore data file %s modified time: %v", v.Id, v.FileName(".dat"), err)
}
}