Fix use of private tags.

Issue #1553

Change-Id: I8c0412eda3d68f2ad475bf8282afcaeffd80852a
This commit is contained in:
Jacob Trimble
2019-08-13 10:41:33 -07:00
parent 79aae2aeaf
commit 0f92d8221f
8 changed files with 13 additions and 3 deletions
+2
View File
@@ -207,6 +207,7 @@ shaka.dash.SegmentBase = class {
*
* @param {shaka.dash.DashParser.Context} context
* @return {?{start: number, end: number}}
* @private
*/
static computeIndexRange_(context) {
const MpdUtils = shaka.dash.MpdUtils;
@@ -231,6 +232,7 @@ shaka.dash.SegmentBase = class {
*
* @param {shaka.dash.DashParser.Context} context
* @return {!Array.<string>}
* @private
*/
static computeIndexUris_(context) {
const ManifestParserUtils = shaka.util.ManifestParserUtils;
+1
View File
@@ -797,6 +797,7 @@ shaka.hls.HlsParser = class {
* @param {!shaka.hls.Tag} tag
* @param {string} type
* @return {Map.<string, string>} closedCaptions
* @private
*/
getClosedCaptions_(tag, type) {
const ContentType = shaka.util.ManifestParserUtils.ContentType;
+1
View File
@@ -656,6 +656,7 @@ shaka.media.StreamingEngine = class {
* @param {!shaka.media.StreamingEngine.MediaState_} mediaState
* @param {number} periodIndex
* @return {boolean}
* @private
*/
shouldAbortCurrentRequest_(mediaState, periodIndex) {
// If the operation is completed, it will be set to null, and there's no
+1
View File
@@ -117,6 +117,7 @@ shaka.media.VideoWrapper = class {
* set the start time once the element is ready.
*
* @param {number} startTime
* @private
*/
delaySetStartTime_(startTime) {
const readyEvent = 'loadedmetadata';
+3
View File
@@ -1514,6 +1514,7 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
* @param {shaka.routing.Payload} has
* @param {shaka.routing.Payload} wants
* @return {!Promise}
* @private
*/
async onInitializeDrm_(has, wants) {
goog.asserts.assert(
@@ -1745,6 +1746,7 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
* @param {shaka.routing.Payload} has
* @param {shaka.routing.Payload} wants
* @return {!Promise}
* @private
*/
async onInitializeSrcEqualsDrm_(has, wants) {
const ContentType = shaka.util.ManifestParserUtils.ContentType;
@@ -2166,6 +2168,7 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
* can monitor our buffer lead during playback.
*
* @param {number} rebufferingGoal
* @private
*/
startBufferManagement_(rebufferingGoal) {
goog.asserts.assert(
+3 -3
View File
@@ -222,14 +222,14 @@ shaka.text.TtmlTextParser = class {
* @return {string}
* @private
*/
static sanitizeTextContent(element, whitespaceTrim) {
static sanitizeTextContent_(element, whitespaceTrim) {
let payload = '';
for (const node of element.childNodes) {
if (node.nodeName == 'br' && element.childNodes[0] !== node) {
payload += '\n';
} else if (node.childNodes && node.childNodes.length > 0) {
payload += shaka.text.TtmlTextParser.sanitizeTextContent(
payload += shaka.text.TtmlTextParser.sanitizeTextContent_(
/** @type {!Element} */ (node),
whitespaceTrim
);
@@ -328,7 +328,7 @@ shaka.text.TtmlTextParser = class {
/\w+/.test(childNode.textContent)
)
) {
payload = shaka.text.TtmlTextParser.sanitizeTextContent(
payload = shaka.text.TtmlTextParser.sanitizeTextContent_(
cueElement,
whitespaceTrim,
);
+1
View File
@@ -168,6 +168,7 @@ shaka.util.Platform = class {
* Cached elements expire in one second so that they can be GC'd or removed.
*
* @return {!HTMLMediaElement}
* @private
*/
static anyMediaElement_() {
const Platform = shaka.util.Platform;
+1
View File
@@ -135,6 +135,7 @@ shaka.ui.PresentationTimeTracker = class extends shaka.ui.Element {
/**
* Set the aria label to be 'Live' when the content is live stream.
* @private
*/
onTracksChanged_() {
if (this.player.isLive()) {