viaprog/shaka-player
1
0
Fork 0
mirror of https://github.com/shaka-project/shaka-player.git synced 2026-06-13 15:46:46 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(ABR): Fix playbackRate calculation when using droppedFrames (#10011)

Browse Source
This commit is contained in:
Álvaro Velad Galván
2026-04-21 11:41:26 +02:00
committed by GitHub
parent 82e914740c
commit 62ea2f6c5c
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/abr/simple_abr_manager.js
+3 -1
View File
@@ -692,7 +692,9 @@ shaka.abr.SimpleAbrManager = class {
// Skip ban logic when playback rate is greater than 1x
// because frame drops are expected or when the total frames are 0.
if (this.mediaElement_.playbackRate > 1 || !currentTotal) {
const playbackRate =
!isNaN(this.playbackRate_) ? Math.abs(this.playbackRate_) : 1;
if (playbackRate > 1 || !currentTotal) {
this.lastDroppedFrames_ = currentDropped;
this.lastTotalFrames_ = currentTotal;
return;
test/abr/simple_abr_manager_unit.js
+3 -3
View File
@@ -474,7 +474,7 @@ describe('SimpleAbrManager', () => {
abrManager.checkDroppedFrames_();
// High drop ratio at 2x speed — ban logic should be skipped.
mockVideo.playbackRate = 2;
abrManager.playbackRateChanged(2);
mockVideo.getVideoPlaybackQuality = () => makeQuality(50, 200);
abrManager.checkDroppedFrames_();
@@ -486,12 +486,12 @@ describe('SimpleAbrManager', () => {
abrManager.checkDroppedFrames_();
// 2x speed: counters are reset to current values (50, 200).
mockVideo.playbackRate = 2;
abrManager.playbackRateChanged(2);
mockVideo.getVideoPlaybackQuality = () => makeQuality(50, 200);
abrManager.checkDroppedFrames_();
// Back to 1x: 5/100 new drops = 5% < 15% threshold.
mockVideo.playbackRate = 1;
abrManager.playbackRateChanged(1);
mockVideo.getVideoPlaybackQuality = () => makeQuality(55, 300);
abrManager.checkDroppedFrames_();