viaprog/shaka-player
1
0
Fork 0
mirror of https://github.com/shaka-project/shaka-player.git synced 2026-06-26 17:46:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: AD_STARTED fires before ad started with AWS Media Tailor (#5855)

Browse Source 
Fixes https://github.com/shaka-project/shaka-player/issues/5854
This commit is contained in:
Álvaro Velad Galván
2023-11-03 15:58:49 +01:00
committed by GitHub
parent 508e5cfbba
commit b39f33466e
1 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/ads/media_tailor_ad_manager.js
+14 -3
View File
@@ -612,8 +612,13 @@ shaka.ads.MediaTailorAdManager = class {
*/
setupCurrentAdListeners_() {
const MediaTailorAdManager = shaka.ads.MediaTailorAdManager;
this.sendTrackingEvent_(MediaTailorAdManager.IMPRESSION_);
this.sendTrackingEvent_(MediaTailorAdManager.START_);
let needFirstEvents = false;
if (!this.video_.paused) {
this.sendTrackingEvent_(MediaTailorAdManager.IMPRESSION_);
this.sendTrackingEvent_(MediaTailorAdManager.START_);
} else {
needFirstEvents = true;
}
this.adListeners_.push({
target: this.video_,
type: 'volumechange',
@@ -636,7 +641,13 @@ shaka.ads.MediaTailorAdManager = class {
target: this.video_,
type: 'play',
listener: () => {
this.sendTrackingEvent_(MediaTailorAdManager.RESUME_);
if (needFirstEvents) {
this.sendTrackingEvent_(MediaTailorAdManager.IMPRESSION_);
this.sendTrackingEvent_(MediaTailorAdManager.START_);
needFirstEvents = false;
} else {
this.sendTrackingEvent_(MediaTailorAdManager.RESUME_);
}
},
});
this.adListeners_.push({