viaprog/shaka-player
1
0
Fork 0
mirror of https://github.com/shaka-project/shaka-player.git synced 2026-06-13 15:46:46 +03:00
Code Issues Packages Projects Releases Wiki Activity

test: Fix UI tests on SmartTVs (#9660)

Browse Source 
Tests fixed:

```
  UI Customization
    ✗ big buttons only created when configured [Safari 3.0 (Tizen 3.0)]
	Error: Expected 1 to be 0.
	    at <Jasmine>
	    at Function.confirmElementMissing (test/test/util/ui_utils.js:70:29 <- test/test/util/ui_utils.js:139:31)
	    at _callee6$ (test/ui/ui_customization_unit.js:86:13 <- test/ui/ui_customization_unit.js:152:21)
	    at tryCatch (node_modules/@babel/polyfill/dist/polyfill.js:6473:40)
  UI
    controls
      controls-button-panel
        ✗ has default elements [Safari 3.0 (Tizen 3.0)]
	Error: Expected 1 to be 0.
	    at <Jasmine>
	    at Function.confirmElementMissing (test/test/util/ui_utils.js:70:29 <- test/test/util/ui_utils.js:139:31)
	    at _callee15$ (test/ui/ui_unit.js:425:19 <- test/ui/ui_unit.js:506:27)
	    at tryCatch (node_modules/@babel/polyfill/dist/polyfill.js:6473:40)

```
This commit is contained in:
Álvaro Velad Galván
2026-02-05 07:09:13 +01:00
committed by GitHub
parent 2562fcbb5c
commit c200219fa2
2 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/util/config_utils.js
+1 -7
View File
@@ -187,10 +187,6 @@ shaka.util.ConfigUtils = class {
return obj && typeof obj === 'object' && !Array.isArray(obj);
};
const isArrayEmpty = (array) => {
return Array.isArray(array) && array.length === 0;
};
const changes = (object, base) => {
return Object.keys(object).reduce((acc, key) => {
const value = object[key];
@@ -208,7 +204,7 @@ shaka.util.ConfigUtils = class {
acc[key] = diff;
}
} else if (Array.isArray(value) && Array.isArray(base[key])) {
if (!shaka.util.ArrayUtils.hasSameElements(value, base[key])) {
if (!shaka.util.ArrayUtils.equal(value, base[key])) {
acc[key] = value;
}
} else if (Number.isNaN(value) && Number.isNaN(base[key])) {
@@ -228,8 +224,6 @@ shaka.util.ConfigUtils = class {
// Do nothing if it's a HTMLElement
} else if (isObject(obj[key]) && Object.keys(obj[key]).length === 0) {
delete obj[key];
} else if (isArrayEmpty(obj[key])) {
delete obj[key];
} else if (typeof obj[key] == 'function') {
delete obj[key];
} else if (isObject(obj[key])) {
test/ui/ui_unit.js
+1 -1
View File
@@ -422,7 +422,7 @@ describe('UI', () => {
UiUtils.confirmElementFound(videoContainer,
'shaka-big-buttons-container');
// Small play button
UiUtils.confirmElementMissing(videoContainer,
UiUtils.confirmElementFound(videoContainer,
'shaka-play-button');
// Volume bar
UiUtils.confirmElementMissing(controlsButtonPanel,