mirror of
https://github.com/shaka-project/shaka-player.git
synced 2026-06-15 16:06:41 +03:00
Theodore Abshire
c1e817d1a9
According to the output documentation, |MultiMap.get| is supposed to return null "if no such key exists". However, in the case that an object is added to the map and then removed, |MultiMap.get| will return an empty array instead of null. This inconsistency could be relevant for code that tests based on the truthiness of the output, so this CL changes the remove method to delete the array for a given key if it becomes empty. This also adds unit tests for MultiMap. Change-Id: I049fece920883e1cb10c319a3f00156be4ee011b
98 lines
2.4 KiB
JavaScript
98 lines
2.4 KiB
JavaScript
/*! @license
|
|
* Shaka Player
|
|
* Copyright 2016 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
goog.require('shaka.test.Util');
|
|
goog.require('shaka.util.MultiMap');
|
|
|
|
describe('MultiMap', () => {
|
|
/** @type {shaka.util.MultiMap<number>} */
|
|
let map;
|
|
beforeEach(() => {
|
|
map = new shaka.util.MultiMap();
|
|
});
|
|
|
|
describe('push', () => {
|
|
it('makes new key-buckets', () => {
|
|
expect(map.size()).toBe(0);
|
|
map.push('a', 1);
|
|
expect(map.size()).toBe(1);
|
|
});
|
|
|
|
it('adds objects to existing key-buckets', () => {
|
|
map.push('a', 1);
|
|
expect(map.size()).toBe(1);
|
|
map.push('a', 2);
|
|
expect(map.size()).toBe(1);
|
|
});
|
|
});
|
|
|
|
describe('get', () => {
|
|
it('returns values for a key', () => {
|
|
map.push('a', 1);
|
|
map.push('a', 2);
|
|
expect(map.get('a')).toEqual([1, 2]);
|
|
});
|
|
|
|
it('returns null for an unused key', () => {
|
|
map.push('a', 1);
|
|
expect(map.get('b')).toBeNull();
|
|
});
|
|
|
|
it('returns null for a key with all values removed', () => {
|
|
map.push('a', 1);
|
|
expect(map.get('a')).toEqual([1]);
|
|
map.remove('a', 1);
|
|
expect(map.get('b')).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe('getAll', () => {
|
|
it('gets all values among all keys', () => {
|
|
map.push('a', 1);
|
|
map.push('b', 2);
|
|
map.push('c', 3);
|
|
map.push('c', 4);
|
|
expect(map.getAll()).toEqual([1, 2, 3, 4]);
|
|
});
|
|
});
|
|
|
|
describe('remove', () => {
|
|
it('removes values that were added', () => {
|
|
map.push('a', 1);
|
|
map.push('a', 2);
|
|
expect(map.get('a')).toEqual([1, 2]);
|
|
map.remove('a', 1);
|
|
expect(map.get('a')).toEqual([2]);
|
|
});
|
|
});
|
|
|
|
describe('clear', () => {
|
|
it('removes all values', () => {
|
|
map.push('a', 1);
|
|
map.push('b', 2);
|
|
map.push('c', 3);
|
|
map.push('c', 4);
|
|
map.clear();
|
|
expect(map.size()).toBe(0);
|
|
});
|
|
});
|
|
|
|
describe('forEach', () => {
|
|
it('iterates over all values', () => {
|
|
map.push('a', 1);
|
|
map.push('b', 2);
|
|
map.push('c', 3);
|
|
map.push('c', 4);
|
|
const callbackSpy = jasmine.createSpy('callbackSpy');
|
|
map.forEach(shaka.test.Util.spyFunc(callbackSpy));
|
|
expect(callbackSpy).toHaveBeenCalledTimes(3);
|
|
expect(callbackSpy).toHaveBeenCalledWith('a', [1]);
|
|
expect(callbackSpy).toHaveBeenCalledWith('b', [2]);
|
|
expect(callbackSpy).toHaveBeenCalledWith('c', [3, 4]);
|
|
});
|
|
});
|
|
});
|